cc: Add more traces to checker imaging / image hijack code paths.

cc: Add more traces to checker imaging / image hijack code paths.

This patch adds a few more disabled by default cc.debug traces to
help follow the code flow through checker imaging and image hijack
canvas.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2746153004
Cr-Commit-Position: refs/heads/master@{#456963}
Committed: https://chromium.googlesource.com/chromium/src/+/5f6ee0e6d3847f0434495e7a40a618fb0eecf27b

[vmpstr, 2017-03-14 20:09:00]

Description was changed from

==========
cc: Add more traces to checker imaging / image hijack code paths.

This patch adds a few more disabled by default cc.debug traces to
help follow the code flow through checker imaging and image hijack
canvas.

R=khushalsagar@chromium.org
==========

to

==========
cc: Add more traces to checker imaging / image hijack code paths.

This patch adds a few more disabled by default cc.debug traces to
help follow the code flow through checker imaging and image hijack
canvas.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-03-14 20:09:33]

Please take a look.

[Khushal, 2017-03-14 20:15:20]

https://codereview.chromium.org/2746153004/diff/1/cc/tiles/checker_image_trac...
File cc/tiles/checker_image_tracker.cc (right):

https://codereview.chromium.org/2746153004/diff/1/cc/tiles/checker_image_trac...
cc/tiles/checker_image_tracker.cc:89:
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
Is the async one we already have here not enough?

[vmpstr, 2017-03-14 20:28:28]

https://codereview.chromium.org/2746153004/diff/1/cc/tiles/checker_image_trac...
File cc/tiles/checker_image_tracker.cc (right):

https://codereview.chromium.org/2746153004/diff/1/cc/tiles/checker_image_trac...
cc/tiles/checker_image_tracker.cc:89:
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
On 2017/03/14 20:15:19, Khushal wrote:
> Is the async one we already have here not enough?

It appears in a different spot in the timeline view, so it would be nice to see
where it corresponds on the thread.

[Khushal, 2017-03-14 20:32:17]

lgtm

[vmpstr, 2017-03-14 20:32:33]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-03-14 20:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:55:13]

Failed to apply patch for cc/tiles/checker_image_tracker.cc:
While running git apply --index -p1;
  error: patch failed: cc/tiles/checker_image_tracker.cc:39
  error: cc/tiles/checker_image_tracker.cc: patch does not apply

Patch:       cc/tiles/checker_image_tracker.cc
Index: cc/tiles/checker_image_tracker.cc
diff --git a/cc/tiles/checker_image_tracker.cc
b/cc/tiles/checker_image_tracker.cc
index
c8113d4d56052edb486948d64999a2680ce952d8..0d19404071806701c86bde12e52050d726aa7f85
100644
--- a/cc/tiles/checker_image_tracker.cc
+++ b/cc/tiles/checker_image_tracker.cc
@@ -39,6 +39,9 @@ void CheckerImageTracker::FilterImagesForCheckeringForTile(
     std::vector<DrawImage>* images,
     ImageIdFlatSet* checkered_images,
     WhichTree tree) {
+  TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
+               "CheckerImageTracker::FilterImagesForCheckeringForTile", "tree",
+               tree);
   DCHECK(checkered_images->empty());
 
   auto images_to_checker = std::remove_if(
@@ -57,6 +60,8 @@ void CheckerImageTracker::FilterImagesForCheckeringForTile(
 }
 
 const ImageIdFlatSet& CheckerImageTracker::TakeImagesToInvalidateOnSyncTree() {
+  TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
+               "CheckerImageTracker::TakeImagesToInvalidateOnSyncTree");
   DCHECK_EQ(invalidated_images_on_current_sync_tree_.size(), 0u)
       << "Sync tree can not be invalidated more than once";
 
@@ -66,6 +71,8 @@ const ImageIdFlatSet&
CheckerImageTracker::TakeImagesToInvalidateOnSyncTree() {
 }
 
 void CheckerImageTracker::DidActivateSyncTree() {
+  TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
+               "CheckerImageTracker::DidActivateSyncTree");
   for (auto image_id : invalidated_images_on_current_sync_tree_) {
     auto it = image_id_to_decode_request_id_.find(image_id);
     image_controller_->UnlockImageDecode(it->second);
@@ -79,6 +86,8 @@ void CheckerImageTracker::DidFinishImageDecode(
     ImageId image_id,
     ImageController::ImageDecodeRequestId request_id,
     ImageController::ImageDecodeResult result) {
+  TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
+               "CheckerImageTracker::DidFinishImageDecode");
   TRACE_EVENT_ASYNC_END0("cc", "CheckerImageTracker::DeferImageDecode",
                          image_id);
 
@@ -131,6 +140,8 @@ bool CheckerImageTracker::ShouldCheckerImage(const
sk_sp<const SkImage>& image,
 
 void CheckerImageTracker::ScheduleImageDecodeIfNecessary(
     const sk_sp<const SkImage>& image) {
+  TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("cc.debug"),
+               "CheckerImageTracker::ScheduleImageDecodeIfNecessary");
   ImageId image_id = image->uniqueID();
 
   // If the image has already been decoded, or a decode request is pending, we

[vmpstr, 2017-03-15 00:18:36]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-03-15 00:18:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2746153004/#ps20001
(title: "rebase?")

[commit-bot: I haz the power, 2017-03-15 00:19:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:43:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489537116869080,
"parent_rev": "1e74b0fb5e282ee32ac9c92e3b037860de981832", "commit_rev":
"5f6ee0e6d3847f0434495e7a40a618fb0eecf27b"}

[commit-bot: I haz the power, 2017-03-15 02:43:55]

Description was changed from

==========
cc: Add more traces to checker imaging / image hijack code paths.

This patch adds a few more disabled by default cc.debug traces to
help follow the code flow through checker imaging and image hijack
canvas.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add more traces to checker imaging / image hijack code paths.

This patch adds a few more disabled by default cc.debug traces to
help follow the code flow through checker imaging and image hijack
canvas.

R=khushalsagar@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2746153004
Cr-Commit-Position: refs/heads/master@{#456963}
Committed:
https://chromium.googlesource.com/chromium/src/+/5f6ee0e6d3847f0434495e7a40a6...
==========

[commit-bot: I haz the power, 2017-03-15 02:43:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5f6ee0e6d3847f0434495e7a40a6...