MD Settings: Use correct change event for noSetPref

MD Settings: Use correct change event for noSetPref

BUG=701508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2746143004
Cr-Commit-Position: refs/heads/master@{#456894}
Committed: https://chromium.googlesource.com/chromium/src/+/9dc27cfc2e8320bd65f4da58debc5569cf8de443

[stevenjb, 2017-03-14 20:42:03]

Description was changed from

==========
MD Settings: Use correct change event for noSetPref

BUG=701508
==========

to

==========
MD Settings: Use correct change event for noSetPref

BUG=701508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-03-14 20:54:44]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-14 21:52:59]

i would highly recommend writing a test for this

[Dan Beam, 2017-03-14 21:53:02]

lgtm

[stevenjb, 2017-03-14 22:00:37]

On 2017/03/14 21:53:02, Dan Beam wrote:
> lgtm

I thought about that, but I'm not really sure what to test. Testing that
on-settings-boolean-control-change gets fired would be straightforward, but
would not have caught these errors. I'll think about what might have helped
here.

[stevenjb, 2017-03-14 22:00:41]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-03-14 22:01:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 23:42:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489528841610700, "parent_rev":
"2ff97c10b4f5ba659bce7de71fa8cd6f818d3839", "commit_rev":
"9dc27cfc2e8320bd65f4da58debc5569cf8de443"}

[commit-bot: I haz the power, 2017-03-14 23:43:11]

Description was changed from

==========
MD Settings: Use correct change event for noSetPref

BUG=701508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Use correct change event for noSetPref

BUG=701508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2746143004
Cr-Commit-Position: refs/heads/master@{#456894}
Committed:
https://chromium.googlesource.com/chromium/src/+/9dc27cfc2e8320bd65f4da58debc...
==========

[commit-bot: I haz the power, 2017-03-14 23:43:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9dc27cfc2e8320bd65f4da58debc...