Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2746053003: [DevTools] replaced slow ::serialize with StringBuilder (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] replaced slow ::serialize with StringBuilder FrameId format is "%d.%d" so we can just generate json string without expensive json serializer. BUG=chromium:588893 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2746053003 Cr-Commit-Position: refs/heads/master@{#458161} Committed: https://chromium.googlesource.com/chromium/src/+/dc22b660b873876614eb65b97924ad32a052ebae

Patch Set 1 #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
kozy
Dmitry, please take a look.
3 years, 9 months ago (2017-03-13 15:09:19 UTC) #2
dgozman
lgtm
3 years, 9 months ago (2017-03-13 16:50:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746053003/20001
3 years, 9 months ago (2017-03-20 17:50:28 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:15:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc22b660b873876614eb65b97924...

Powered by Google App Engine
This is Rietveld 408576698