Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2746053002: Fix Template Parameter List for Associative Containers in base::EraseIf (Closed)

Created:
3 years, 9 months ago by jdoerrie
Modified:
3 years, 9 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Template Parameter List for Associative Containers in base::EraseIf This change fixes the template parameter lists of associative containers for base::EraseIf. For example, trying to use base::EraseIf with a std::map using a custom comparator would have resulted in a compilation error before this change. BUG=697235 R=dyaroshev@yandex-team.ru, danakj@chromium.org, pkasting@chromium.org Review-Url: https://codereview.chromium.org/2746053002 Cr-Commit-Position: refs/heads/master@{#456385} Committed: https://chromium.googlesource.com/chromium/src/+/5dd3a2137bac37d60ec0d4b43cdbcb8eb9d44879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M base/stl_util.h View 1 chunk +41 lines, -16 lines 0 comments Download
M base/stl_util_unittest.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jdoerrie
Dear all, please review.
3 years, 9 months ago (2017-03-13 07:45:59 UTC) #3
dyaroshev
On 2017/03/13 07:45:59, jdoerrie wrote: > Dear all, please review. LGTM.
3 years, 9 months ago (2017-03-13 07:48:30 UTC) #4
danakj
LGTM
3 years, 9 months ago (2017-03-13 14:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746053002/1
3 years, 9 months ago (2017-03-13 14:56:27 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 15:31:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5dd3a2137bac37d60ec0d4b43cdb...

Powered by Google App Engine
This is Rietveld 408576698