Chromium Code Reviews
Help | Chromium Project | Sign in
(114)

Issue 2746013010: Consistent pagination strut propagation policies. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by mstensho
Modified:
1 week ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistent pagination strut propagation policies. There's no break opportunity between a spanner and the next block in a column. Also no break opportunity between a float and an in-flow block. The spec is a bit vague here, but our implementation certainly doesn't support it. We have to prevent strut propagation in such cases. If the first piece of content inside the block (e.g. a line) doesn't fit inside the current fragmentainer, it's the line that needs to be pushed, not the block. One of the tests included here used to cause a DCHECK failure. Review-Url: https://codereview.chromium.org/2746013010 Cr-Commit-Position: refs/heads/master@{#457888} Committed: https://chromium.googlesource.com/chromium/src/+/d79ffe1a26f9a6f9572cff9c2e5f12a119032c64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner.html View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner-2.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner-2-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner-and-float.html View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner-and-float-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/outer-column-break-after-inner-spanner-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/block-after-float-first-child.html View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/block-after-float-first-child-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +14 lines, -4 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (12 generated)
mstensho
1 week ago (2017-03-17 20:23:56 UTC) #10
eae
Code change LGTM and I do like the new tests! Out of curiosity, which DCHECK ...
1 week ago (2017-03-17 20:46:13 UTC) #11
mstensho
On 2017/03/17 20:46:13, eae wrote: > Code change LGTM and I do like the new ...
1 week ago (2017-03-17 20:58:06 UTC) #12
eae
Ah, that makes sense. Thanks for clarifying! LGTM
1 week ago (2017-03-17 20:59:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013010/1
1 week ago (2017-03-17 21:18:58 UTC) #15
commit-bot: I haz the power
1 week ago (2017-03-17 21:27:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d79ffe1a26f9a6f9572cff9c2e5f...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62