Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(261)

Issue 2746013010: Consistent pagination strut propagation policies. (Closed)

Created:
11 months, 1 week ago by mstensho (USE GERRIT)
Modified:
11 months, 1 week ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistent pagination strut propagation policies. There's no break opportunity between a spanner and the next block in a column. Also no break opportunity between a float and an in-flow block. The spec is a bit vague here, but our implementation certainly doesn't support it. We have to prevent strut propagation in such cases. If the first piece of content inside the block (e.g. a line) doesn't fit inside the current fragmentainer, it's the line that needs to be pushed, not the block. One of the tests included here used to cause a DCHECK failure. Review-Url: https://codereview.chromium.org/2746013010 Cr-Commit-Position: refs/heads/master@{#457888} Committed: https://chromium.googlesource.com/chromium/src/+/d79ffe1a26f9a6f9572cff9c2e5f12a119032c64

Patch Set 1 #

Messages

Total messages: 18 (12 generated)
mstensho (USE GERRIT)
11 months, 1 week ago (2017-03-17 20:23:56 UTC) #10
eae
Code change LGTM and I do like the new tests! Out of curiosity, which DCHECK ...
11 months, 1 week ago (2017-03-17 20:46:13 UTC) #11
mstensho (USE GERRIT)
On 2017/03/17 20:46:13, eae wrote: > Code change LGTM and I do like the new ...
11 months, 1 week ago (2017-03-17 20:58:06 UTC) #12
eae
Ah, that makes sense. Thanks for clarifying! LGTM
11 months, 1 week ago (2017-03-17 20:59:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013010/1
11 months, 1 week ago (2017-03-17 21:18:58 UTC) #15
commit-bot: I haz the power
11 months, 1 week ago (2017-03-17 21:27:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d79ffe1a26f9a6f9572cff9c2e5f...

Powered by Google App Engine
This is Rietveld 408576698