Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2746013009: Use NearbyPermissions.BLE for Physical Web (Closed)

Created:
3 years, 9 months ago by cco3
Modified:
3 years, 9 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NearbyPermissions.BLE for Physical Web This determines the scope of permissions that Nearby needs. This will avoid the permissions dialogue when we have ACCESS_FINE_LOCATION. BUG=702278 Review-Url: https://codereview.chromium.org/2746013009 Cr-Commit-Position: refs/heads/master@{#459125} Committed: https://chromium.googlesource.com/chromium/src/+/faba79b70831e1f83d831419ba6d58e1cc3ed461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbySubscription.java View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cco3
3 years, 9 months ago (2017-03-16 17:45:48 UTC) #2
mattreynolds
lgtm
3 years, 9 months ago (2017-03-16 19:58:49 UTC) #3
cco3
Hi Tommy, this is one of two changes upstreaming some code. (There will be two ...
3 years, 9 months ago (2017-03-16 20:06:17 UTC) #5
nyquist
lgtm
3 years, 9 months ago (2017-03-23 15:16:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013009/1
3 years, 9 months ago (2017-03-23 16:42:57 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 17:18:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/faba79b70831e1f83d831419ba6d...

Powered by Google App Engine
This is Rietveld 408576698