Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2746013008: Use FPDFPageObj_NewImageObj() instead of FPDFPageObj_NewImgeObj(). (Closed)

Created:
3 years, 9 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FPDFPageObj_NewImageObj() instead of FPDFPageObj_NewImgeObj(). Review-Url: https://codereview.chromium.org/2746013008 Cr-Commit-Position: refs/heads/master@{#457683} Committed: https://chromium.googlesource.com/chromium/src/+/773c7903f1735bccfe48dd4987c4f2a87522f5b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pdf/pdfium/pdfium_engine.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Lei Zhang
"I would like to buy an 'a' please."
3 years, 9 months ago (2017-03-16 00:37:33 UTC) #2
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-16 18:02:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013008/1
3 years, 9 months ago (2017-03-16 18:03:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/33865)
3 years, 9 months ago (2017-03-16 18:14:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013008/1
3 years, 9 months ago (2017-03-17 03:36:47 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 04:29:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/773c7903f1735bccfe48dd4987c4...

Powered by Google App Engine
This is Rietveld 408576698