use VideoColorSpace in decoder configuration

use VideoColorSpace in decoder configuration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2746013006
Cr-Commit-Position: refs/heads/master@{#459144}
Committed: https://chromium.googlesource.com/chromium/src/+/8522682ae8653566035cd5dd41ebd2679e5aaa2b

[hubbe, 2017-03-15 00:24:40]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:25:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 00:30:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 00:30:40]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[hubbe, 2017-03-15 20:53:40]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 20:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 21:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 21:13:00]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hubbe, 2017-03-15 22:31:19]

Description was changed from

==========
use VideoColorSpace in decoder configuration
==========

to

==========
use VideoColorSpace in decoder configuration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[hubbe, 2017-03-15 22:31:35]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-03-15 23:42:38]

hubbe@chromium.org changed reviewers:
+ ccameron@chromium.org

[hubbe, 2017-03-15 23:42:39]

I don't think I'm going to use VideoColorSpace in VideoFrame, since that would
mean that I would have to add support for scRGB and other internally used
formats to VideoColorSpace.

[commit-bot: I haz the power, 2017-03-16 00:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 00:33:37]

Dry run: This issue passed the CQ dry run.

[hubbe, 2017-03-20 21:50:15]

On 2017/03/15 23:42:39, hubbe wrote:
> I don't think I'm going to use VideoColorSpace in VideoFrame, since that would
> mean that I would have to add support for scRGB and other internally used
> formats to VideoColorSpace.

Ping?

[ccameron, 2017-03-20 21:58:24]

lgtm (sorry for the delay! somehow I thought someone else had media/)

https://codereview.chromium.org/2746013006/diff/40001/media/filters/vpx_video...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/2746013006/diff/40001/media/filters/vpx_video...
media/filters/vpx_video_decoder.cc:601: if (config_.color_space_info() !=
VideoColorSpace()) {
IsValid (if you want ... we got in the habit of "compare against default ctor",
and only added IsValid for gfx::ColorSpace later ... your call).

[hubbe, 2017-03-20 22:03:09]

https://codereview.chromium.org/2746013006/diff/40001/media/filters/vpx_video...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/2746013006/diff/40001/media/filters/vpx_video...
media/filters/vpx_video_decoder.cc:601: if (config_.color_space_info() !=
VideoColorSpace()) {
On 2017/03/20 21:58:24, ccameron wrote:
> IsValid (if you want ... we got in the habit of "compare against default
ctor",
> and only added IsValid for gfx::ColorSpace later ... your call).

IsValid() and comparing against ctor have different meanings here, as a video
color space can have *some* valid components, while others are not. A partially
valid video color space is still a good hint which should let us infer the other
values, so we want to use it.

[hubbe, 2017-03-20 22:03:26]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:04:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 22:25:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 22:25:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hubbe, 2017-03-22 23:00:38]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:01:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hubbe, 2017-03-22 23:01:33]

hubbe@chromium.org changed reviewers:
+ tsepez@chromium.org

[hubbe, 2017-03-22 23:01:34]

+tsepez for security (media/base/ipc/media_param_traits_macros.h)

[commit-bot: I haz the power, 2017-03-22 23:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:36:34]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[hubbe, 2017-03-23 00:26:51]

The CQ bit was checked by hubbe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 00:27:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 02:04:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:04:22]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-03-23 16:35:16]

lgtm

[hubbe, 2017-03-23 17:42:19]

The CQ bit was checked by hubbe@chromium.org

[hubbe, 2017-03-23 17:42:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2746013006/#ps80001
(title: "oops, win compile fix reapplied")

[commit-bot: I haz the power, 2017-03-23 17:43:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:09:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490290939828850,
"parent_rev": "b5e4d136a6287e8fe9108fcaafdfecb4edae713e", "commit_rev":
"8522682ae8653566035cd5dd41ebd2679e5aaa2b"}

[commit-bot: I haz the power, 2017-03-23 18:10:38]

Description was changed from

==========
use VideoColorSpace in decoder configuration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
use VideoColorSpace in decoder configuration
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2746013006
Cr-Commit-Position: refs/heads/master@{#459144}
Committed:
https://chromium.googlesource.com/chromium/src/+/8522682ae8653566035cd5dd41eb...
==========

[commit-bot: I haz the power, 2017-03-23 18:10:40]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/8522682ae8653566035cd5dd41eb...