Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2746013002: [turbofan] Less aggressively insert SOFT deopts for property access. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Less aggressively insert SOFT deopts for property access. Sometimes TurboFan is able to extract receiver maps from the surrounding graph and thus is able to generate reasonable code for property accesses, even if those haven't been executed in the baseline tier yet. So, only stick in an SOFT deoptimization exit, if ExtractReceiverMaps failed to infer proper receiver maps. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2746013002 Cr-Commit-Position: refs/heads/master@{#43736} Committed: https://chromium.googlesource.com/v8/v8/+/b8453628c94ddf71e05d70471355c7c924bbcf31

Patch Set 1 #

Patch Set 2 : Work-around for JSFunctions without context. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -23 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 4 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-13 06:12:58 UTC) #1
Yang
On 2017/03/13 06:12:58, Benedikt Meurer wrote: lgtm, but tests fail :)
3 years, 9 months ago (2017-03-13 06:30:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746013002/20001
3 years, 9 months ago (2017-03-13 07:04:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/b8453628c94ddf71e05d70471355c7c924bbcf31
3 years, 9 months ago (2017-03-13 07:23:51 UTC) #15
Benedikt Meurer
3 years, 9 months ago (2017-03-13 11:46:43 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2748663002/ by bmeurer@chromium.org.

The reason for reverting is: Tanks Octane/Mandreel and Octane/MandreelLatency..

Powered by Google App Engine
This is Rietveld 408576698