Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2745963002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in cc/trees/ (Closed)

Created:
3 years, 9 months ago by Byoungkwon Ko
Modified:
3 years, 9 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in cc/trees/ BUG=644626 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2745963002 Cr-Commit-Position: refs/heads/master@{#456375} Committed: https://chromium.googlesource.com/chromium/src/+/178891545bb2f76efeb22802e069de1be23712f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Byoungkwon Ko
PTAL
3 years, 9 months ago (2017-03-12 15:09:07 UTC) #7
ajuma
lgtm
3 years, 9 months ago (2017-03-13 14:12:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745963002/1
3 years, 9 months ago (2017-03-13 14:30:42 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 14:35:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/178891545bb2f76efeb22802e069...

Powered by Google App Engine
This is Rietveld 408576698