Remove enable_webvr from build/config, and move it to the buildflag_header system.

Remove enable_webvr from build/config, and move it to the buildflag_header system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
TBR=avi
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745943002
Cr-Commit-Position: refs/heads/master@{#456738}
Committed: https://chromium.googlesource.com/chromium/src/+/49a841a4fa2889833c8181cc18eae546db9370f7

[Nico, 2017-03-11 21:24:51]

Description was changed from

==========
Remove enable_webrtc from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
==========

to

==========
Remove enable_webrtc from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Nico, 2017-03-11 21:24:56]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 21:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-11 21:27:22]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2017-03-11 21:27:30]

thakis@chromium.org changed reviewers:
+ bajones@chromium.org

[commit-bot: I haz the power, 2017-03-11 21:27:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 22:25:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 22:25:19]

Dry run: This issue passed the CQ dry run.

[Nico, 2017-03-11 23:09:38]

Description was changed from

==========
Remove enable_webrtc from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove enable_webvr from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Nico, 2017-03-11 23:10:08]

Err this is about webvr, not webrtc, sorry.

[Nico, 2017-03-13 21:23:53]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 21:24:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-13 23:15:17]

bajones: Ping

On Mar 11, 2017 6:10 PM, <thakis@chromium.org> wrote:

> Err this is about webvr, not webrtc, sorry.
>
> https://codereview.chromium.org/2745943002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-03-13 23:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 23:18:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-03-13 23:22:45]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 23:23:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2017-03-13 23:46:18]

On 2017/03/13 23:15:17, Nico wrote:
> bajones: Ping
> 
> On Mar 11, 2017 6:10 PM, <mailto:thakis@chromium.org> wrote:
> 
> > Err this is about webvr, not webrtc, sorry.
> >
> > https://codereview.chromium.org/2745943002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

LGTM

[Nico, 2017-03-14 00:46:43]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-03-14 00:46:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:47:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 00:55:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:55:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2017-03-14 00:59:07]

Description was changed from

==========
Remove enable_webvr from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove enable_webvr from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
TBR=avi
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Nico, 2017-03-14 00:59:25]

thakis@chromium.org changed reviewers:
+ avi@chromium.org

[Nico, 2017-03-14 00:59:26]

tbr avi for the two mechanical changes in content/

[Nico, 2017-03-14 00:59:35]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-14 01:00:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 02:18:44]

Failed to apply patch for chrome/common/url_constants.h:
While running git apply --index -p1;
  error: patch failed: chrome/common/url_constants.h:15
  error: chrome/common/url_constants.h: patch does not apply

Patch:       chrome/common/url_constants.h
Index: chrome/common/url_constants.h
diff --git a/chrome/common/url_constants.h b/chrome/common/url_constants.h
index
4cf07a2ca9b80582b0788909484c70d7b6c05bd5..b8ebbb655fc1aa792fb0e0fa1e0d58d2b116e967
100644
--- a/chrome/common/url_constants.h
+++ b/chrome/common/url_constants.h
@@ -15,6 +15,7 @@
 #include "build/build_config.h"
 #include "chrome/common/features.h"
 #include "content/public/common/url_constants.h"
+#include "device/vr/features.h"
 #include "media/media_features.h"
 #include "printing/features/features.h"
 
@@ -269,7 +270,7 @@ extern const char kChromeUISnippetsInternalsHost[];
 extern const char kChromeUIWebApksHost[];
 #endif
 
-#if defined(ENABLE_WEBVR)
+#if BUILDFLAG(ENABLE_WEBVR)
 extern const char kChromeUIVrShellUIHost[];
 #endif

[Nico, 2017-03-14 15:28:35]

The CQ bit was checked by thakis@chromium.org

[Nico, 2017-03-14 15:28:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bajones@chromium.org
Link to the patchset: https://codereview.chromium.org/2745943002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-14 15:29:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 17:02:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489505315847920,
"parent_rev": "37e768daa8579acfc7e046c9decfaa75488b7847", "commit_rev":
"49a841a4fa2889833c8181cc18eae546db9370f7"}

[commit-bot: I haz the power, 2017-03-14 17:05:53]

Description was changed from

==========
Remove enable_webvr from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
TBR=avi
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove enable_webvr from build/config, and move it to the buildflag_header
system.

No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.

BUG=none
TBR=avi
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2745943002
Cr-Commit-Position: refs/heads/master@{#456738}
Committed:
https://chromium.googlesource.com/chromium/src/+/49a841a4fa2889833c8181cc18ea...
==========

[commit-bot: I haz the power, 2017-03-14 17:05:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/49a841a4fa2889833c8181cc18ea...