Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2745933002:
Roll DEPS for sfntly 64f7856..84f7108 (Closed)
DescriptionRoll DEPS for sfntly 64f7856..84f7108
84f7108 Fix 'INCLUDE WHAT YOU USE' violation (#73)
ed46801 Merge pull request #69 from HalCanary/cpp_cleanup_part_1
5ae041c Sfntly C++ Cleanup
b1fbadb Merge pull request #68 from jfkthame/patch-1
38cc8d2 Fix incorrect test reported in glyph_table.cc
BUG=693640
Review-Url: https://codereview.chromium.org/2745933002
Cr-Commit-Position: refs/heads/master@{#456878}
Committed: https://chromium.googlesource.com/chromium/src/+/ba7249e429cce02e006b08b1298765699dd48ea2
Patch Set 1 #Messages
Total messages: 21 (12 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + behdad@chromium.org
thestig@chromium.org changed reviewers: + jshin@chromium.org
+jshin since this roll is part of https://codereview.chromium.org/2740673002/ as well.
On 2017/03/14 18:26:14, Lei Zhang (super slow) wrote: > +jshin since this roll is part of https://codereview.chromium.org/2740673002/ as > well. Thanks, Lei ! For the record, can you add 'BUG=693640' line to the CL description? LGTM
Description was changed from ========== Roll DEPS for sfntly 64f7856..84f7108 84f7108 Fix 'INCLUDE WHAT YOU USE' violation (#73) ed46801 Merge pull request #69 from HalCanary/cpp_cleanup_part_1 5ae041c Sfntly C++ Cleanup b1fbadb Merge pull request #68 from jfkthame/patch-1 38cc8d2 Fix incorrect test reported in glyph_table.cc ========== to ========== Roll DEPS for sfntly 64f7856..84f7108 84f7108 Fix 'INCLUDE WHAT YOU USE' violation (#73) ed46801 Merge pull request #69 from HalCanary/cpp_cleanup_part_1 5ae041c Sfntly C++ Cleanup b1fbadb Merge pull request #68 from jfkthame/patch-1 38cc8d2 Fix incorrect test reported in glyph_table.cc BUG=693640 ==========
The CQ bit was checked by thestig@chromium.org
On 2017/03/14 19:52:19, jungshik at Google wrote: > For the record, can you add 'BUG=693640' line to the CL description? Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489527036933870, "parent_rev":
"50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf", "commit_rev":
"ba7249e429cce02e006b08b1298765699dd48ea2"}
Message was sent while issue was closed.
Description was changed from ========== Roll DEPS for sfntly 64f7856..84f7108 84f7108 Fix 'INCLUDE WHAT YOU USE' violation (#73) ed46801 Merge pull request #69 from HalCanary/cpp_cleanup_part_1 5ae041c Sfntly C++ Cleanup b1fbadb Merge pull request #68 from jfkthame/patch-1 38cc8d2 Fix incorrect test reported in glyph_table.cc BUG=693640 ========== to ========== Roll DEPS for sfntly 64f7856..84f7108 84f7108 Fix 'INCLUDE WHAT YOU USE' violation (#73) ed46801 Merge pull request #69 from HalCanary/cpp_cleanup_part_1 5ae041c Sfntly C++ Cleanup b1fbadb Merge pull request #68 from jfkthame/patch-1 38cc8d2 Fix incorrect test reported in glyph_table.cc BUG=693640 Review-Url: https://codereview.chromium.org/2745933002 Cr-Commit-Position: refs/heads/master@{#456878} Committed: https://chromium.googlesource.com/chromium/src/+/ba7249e429cce02e006b08b12987... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ba7249e429cce02e006b08b12987...
Message was sent while issue was closed.
lgtm |
