[WASM] Implement Simd128 Load/Store on ARM.

[WASM] Implement Simd128 Load/Store on ARM.
- Adds new load/store opcodes (0xc0, 0xc1) for S128 type.
- Implements these for ARM.
- Enables more WASM SIMD tests, and adds new LoadStoreLoad test.

LOG=N
BUG=v8:6020
Review-Url: https://codereview.chromium.org/2745853002
Cr-Commit-Position: refs/heads/master@{#43841}
Committed: https://chromium.googlesource.com/v8/v8/+/365492f17e11ee2cfcd0c59acaaf3af13d8de581

[bbudge, 2017-03-15 00:05:09]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-03-15 00:42:40]

Description was changed from

==========
[WASM] Implement Simd128 Load/Store on ARM.

LOG=N
BUG=v8:6020
==========

to

==========
[WASM] Implement Simd128 Load/Store on ARM.
- Adds new load/store opcodes (0xc0, 0xc1) for S128 type.
- Implements these for ARM.
- Enables more WASM SIMD tests, and adds new LoadStoreLoad test.

LOG=N
BUG=v8:6020
==========

[bbudge, 2017-03-15 00:43:18]

The CQ bit was checked by bbudge@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:43:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-03-15 00:43:38]

bbudge@chromium.org changed reviewers:
+ bmeurer@chromium.org

[commit-bot: I haz the power, 2017-03-15 01:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 01:07:21]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-03-15 04:39:07]

Nice. LGTM.

[bbudge, 2017-03-15 16:07:25]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:07:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bbudge, 2017-03-15 16:15:23]

bbudge@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bbudge, 2017-03-15 16:15:24]

+ Brad for wasm

[commit-bot: I haz the power, 2017-03-15 16:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 16:18:39]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/36758)

[bbudge, 2017-03-15 20:02:34]

bbudge@chromium.org changed reviewers:
+ mtrofin@chromium.org
- bradnelson@chromium.org

[bbudge, 2017-03-15 20:02:35]

- Brad
+ Mircea

[bbudge, 2017-03-15 20:02:55]

On 2017/03/15 20:02:35, bbudge wrote:
> - Brad
> + Mircea

for wasm

[Mircea Trofin, 2017-03-15 20:10:28]

lgtm

[bbudge, 2017-03-15 23:04:18]

The CQ bit was checked by bbudge@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:04:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 23:06:02]

Failed to apply patch for test/cctest/wasm/test-run-wasm-simd.cc:
While running git apply --index -p1;
  error: patch failed: test/cctest/wasm/test-run-wasm-simd.cc:1069
  error: test/cctest/wasm/test-run-wasm-simd.cc: patch does not apply

Patch:       test/cctest/wasm/test-run-wasm-simd.cc
Index: test/cctest/wasm/test-run-wasm-simd.cc
diff --git a/test/cctest/wasm/test-run-wasm-simd.cc
b/test/cctest/wasm/test-run-wasm-simd.cc
index
e9500c21def70cfcbe7207e0183efaa3e6a967b1..0f4302e1271c902a2da9fb13df89545efcd92d30
100644
--- a/test/cctest/wasm/test-run-wasm-simd.cc
+++ b/test/cctest/wasm/test-run-wasm-simd.cc
@@ -1069,7 +1069,6 @@ WASM_EXEC_COMPILED_TEST(I32x4ShrU) {
 #endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 
 #if V8_TARGET_ARCH_ARM
-
 void RunI16x8UnOpTest(WasmOpcode simd_op, Int16UnOp expected_op) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, int32_t, int32_t> r(kExecuteCompiled);
@@ -1600,9 +1599,6 @@ WASM_EXEC_COMPILED_TEST(S1x16Or) {
RunS1x16BinOpTest(kExprS1x16Or, Or); }
 
 WASM_EXEC_COMPILED_TEST(S1x16Xor) { RunS1x16BinOpTest(kExprS1x16Xor, Xor); }
 
-#endif  // V8_TARGET_ARCH_ARM
-
-#if SIMD_LOWERING_TARGET
 WASM_EXEC_COMPILED_TEST(SimdI32x4ExtractWithF32x4) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t> r(kExecuteCompiled);
@@ -1656,9 +1652,7 @@ WASM_EXEC_COMPILED_TEST(SimdI32x4AddWithF32x4) {
             WASM_I32V(1), WASM_I32V(0)));
   FOR_INT32_INPUTS(i) { CHECK_EQ(1, r.Call()); }
 }
-#endif  // SIMD_LOWERING_TARGET
 
-#if V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 WASM_EXEC_COMPILED_TEST(SimdI32x4Local) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t> r(kExecuteCompiled);
@@ -1740,9 +1734,7 @@ WASM_EXEC_COMPILED_TEST(SimdF32x4For) {
         WASM_GET_LOCAL(0));
   FOR_INT32_INPUTS(i) { CHECK_EQ(1, r.Call()); }
 }
-#endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 
-#if SIMD_LOWERING_TARGET
 WASM_EXEC_COMPILED_TEST(SimdI32x4GetGlobal) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, int32_t> r(kExecuteCompiled);
@@ -1834,4 +1826,22 @@ WASM_EXEC_COMPILED_TEST(SimdF32x4SetGlobal) {
   CHECK_EQ(*(global + 2), 32.25);
   CHECK_EQ(*(global + 3), 65.0);
 }
-#endif  // SIMD_LOWERING_TARGET
+
+WASM_EXEC_COMPILED_TEST(SimdLoadStoreLoad) {
+  FLAG_wasm_simd_prototype = true;
+  WasmRunner<int32_t> r(kExecuteCompiled);
+  int32_t* memory = r.module().AddMemoryElems<int32_t>(4);
+
+  BUILD(r,
+        WASM_STORE_MEM(MachineType::Simd128(), WASM_ZERO,
+                       WASM_LOAD_MEM(MachineType::Simd128(), WASM_ZERO)),
+        WASM_SIMD_I32x4_EXTRACT_LANE(
+            0, WASM_LOAD_MEM(MachineType::Simd128(), WASM_ZERO)));
+
+  FOR_INT32_INPUTS(i) {
+    int32_t expected = *i;
+    r.module().WriteMemory(&memory[0], expected);
+    CHECK_EQ(expected, r.Call());
+  }
+}
+#endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET

[bbudge, 2017-03-15 23:10:13]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2017-03-15 23:10:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2745853002/#ps80001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-15 23:10:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 23:34:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489619413276500,
"parent_rev": "79e01fd9b03b8202c0662b75a7a95bac07b8745e", "commit_rev":
"365492f17e11ee2cfcd0c59acaaf3af13d8de581"}

[commit-bot: I haz the power, 2017-03-15 23:34:59]

Description was changed from

==========
[WASM] Implement Simd128 Load/Store on ARM.
- Adds new load/store opcodes (0xc0, 0xc1) for S128 type.
- Implements these for ARM.
- Enables more WASM SIMD tests, and adds new LoadStoreLoad test.

LOG=N
BUG=v8:6020
==========

to

==========
[WASM] Implement Simd128 Load/Store on ARM.
- Adds new load/store opcodes (0xc0, 0xc1) for S128 type.
- Implements these for ARM.
- Enables more WASM SIMD tests, and adds new LoadStoreLoad test.

LOG=N
BUG=v8:6020

Review-Url: https://codereview.chromium.org/2745853002
Cr-Commit-Position: refs/heads/master@{#43841}
Committed:
https://chromium.googlesource.com/v8/v8/+/365492f17e11ee2cfcd0c59acaaf3af13d8...
==========

[commit-bot: I haz the power, 2017-03-15 23:35:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/365492f17e11ee2cfcd0c59acaaf3af13d8...

[Michael Achenbach, 2017-03-16 12:37:13]

Breaks a test on arm chromebooks:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2455