ChromeOS OOBE: Fix OK button on Welcome screen.

ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=700643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745843004
Cr-Commit-Position: refs/heads/master@{#456567}
Committed: https://chromium.googlesource.com/chromium/src/+/a45b9f4f9b55667f056c46915642691a112a2a3a

[Alexander Alekseev, 2017-03-11 07:41:39]

Description was changed from

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=690725
==========

to

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=690725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-03-11 07:42:04]

alemate@chromium.org changed reviewers:
+ jdufault@chromium.org

[Alexander Alekseev, 2017-03-11 07:42:04]

Please review.

[Alexander Alekseev, 2017-03-11 07:42:09]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 07:42:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2017-03-11 07:45:05]

Description was changed from

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=690725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=700643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-03-11 08:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 08:37:12]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-12 01:59:53]

lgtm

https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_text_button.css (right):

https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_text_button.css:16: border-color:
rgba(66, 133, 244, 0.4); /* #4284f4 */
Can we make this 4284f4 a constant like --oobe-text-button-border-color? Also
see previous file.

[Alexander Alekseev, 2017-03-13 22:45:31]

https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_text_button.css (right):

https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_text_button.css:16: border-color:
rgba(66, 133, 244, 0.4); /* #4284f4 */
On 2017/03/12 01:59:53, jdufault wrote:
> Can we make this 4284f4 a constant like --oobe-text-button-border-color? Also
> see previous file.

Done.

[Alexander Alekseev, 2017-03-13 22:45:34]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2017-03-13 22:45:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2745843004/#ps20001
(title: "Update after review.")

[commit-bot: I haz the power, 2017-03-13 22:46:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2017-03-13 23:30:32]

The CQ bit was unchecked by alemate@chromium.org

[Alexander Alekseev, 2017-03-14 00:13:24]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2017-03-14 00:13:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2745843004/#ps40001
(title: "Update after review.")

[commit-bot: I haz the power, 2017-03-14 00:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 00:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:27:43]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Alekseev, 2017-03-14 00:51:07]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-03-14 00:51:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 01:59:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489452667971200,
"parent_rev": "c4d682f7e4dc51c7912f5311d170889feeb45ef2", "commit_rev":
"a45b9f4f9b55667f056c46915642691a112a2a3a"}

[commit-bot: I haz the power, 2017-03-14 02:00:18]

Description was changed from

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=700643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: Fix OK button on Welcome screen.

This Cl fixes issue "Let’s go button grows taller when tapped".

BUG=700643
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745843004
Cr-Commit-Position: refs/heads/master@{#456567}
Committed:
https://chromium.googlesource.com/chromium/src/+/a45b9f4f9b55667f056c46915642...
==========

[commit-bot: I haz the power, 2017-03-14 02:00:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a45b9f4f9b55667f056c46915642...