Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2745843004: ChromeOS OOBE: Fix OK button on Welcome screen. (Closed)

Created:
3 years, 9 months ago by Alexander Alekseev
Modified:
3 years, 9 months ago
Reviewers:
jdufault
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: Fix OK button on Welcome screen. This Cl fixes issue "Let’s go button grows taller when tapped". BUG=700643 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2745843004 Cr-Commit-Position: refs/heads/master@{#456567} Committed: https://chromium.googlesource.com/chromium/src/+/a45b9f4f9b55667f056c46915642691a112a2a3a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update after review. #

Patch Set 3 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_buttons.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen.css View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_text_button.css View 1 2 1 chunk +7 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_secondary_button.css View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (16 generated)
Alexander Alekseev
Please review.
3 years, 9 months ago (2017-03-11 07:42:04 UTC) #3
jdufault
lgtm https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/chromeos/login/oobe_text_button.css File chrome/browser/resources/chromeos/login/oobe_text_button.css (right): https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/chromeos/login/oobe_text_button.css#newcode16 chrome/browser/resources/chromeos/login/oobe_text_button.css:16: border-color: rgba(66, 133, 244, 0.4); /* #4284f4 */ ...
3 years, 9 months ago (2017-03-12 01:59:53 UTC) #9
Alexander Alekseev
https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/chromeos/login/oobe_text_button.css File chrome/browser/resources/chromeos/login/oobe_text_button.css (right): https://codereview.chromium.org/2745843004/diff/1/chrome/browser/resources/chromeos/login/oobe_text_button.css#newcode16 chrome/browser/resources/chromeos/login/oobe_text_button.css:16: border-color: rgba(66, 133, 244, 0.4); /* #4284f4 */ On ...
3 years, 9 months ago (2017-03-13 22:45:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745843004/20001
3 years, 9 months ago (2017-03-13 22:46:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745843004/40001
3 years, 9 months ago (2017-03-14 00:13:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/227052) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 9 months ago (2017-03-14 00:27:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745843004/40001
3 years, 9 months ago (2017-03-14 00:51:29 UTC) #21
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:00:19 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a45b9f4f9b55667f056c46915642...

Powered by Google App Engine
This is Rietveld 408576698