Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2745833002: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 9 months ago by ymzhang1
Modified:
3 years, 8 months ago
Reviewers:
Finnur, Theresa
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file( extension, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=finnur@chromium.org Review-Url: https://codereview.chromium.org/2745833002 Cr-Commit-Position: refs/heads/master@{#461109} Committed: https://chromium.googlesource.com/chromium/src/+/eedc8af55aa7e6fea5b8430c2534fe0ce0a3be3a

Patch Set 1 #

Total comments: 6

Patch Set 2 : update component #

Total comments: 2

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/commands/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 9 months ago (2017-03-10 21:20:37 UTC) #1
Finnur
Sorry for the late response, missed this yesterday. https://codereview.chromium.org/2745833002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS (right): https://codereview.chromium.org/2745833002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS#newcode4 chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS:4: # ...
3 years, 9 months ago (2017-03-14 10:31:15 UTC) #2
ymzhang1
+twellington@ Could you help to review the component added in the following files? chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS chrome/android/javatests/src/org/chromium/chrome/browser/preferences/OWNERS ...
3 years, 9 months ago (2017-03-14 23:39:23 UTC) #4
Theresa
https://codereview.chromium.org/2745833002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS (right): https://codereview.chromium.org/2745833002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS#newcode4 chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS:4: # COMPONENT: UI>Browser>Preferences We typically use UI>Settings for bugs ...
3 years, 9 months ago (2017-03-14 23:43:45 UTC) #5
ymzhang1
https://codereview.chromium.org/2745833002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS File chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS (right): https://codereview.chromium.org/2745833002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS#newcode4 chrome/android/java/src/org/chromium/chrome/browser/preferences/OWNERS:4: # COMPONENT: UI>Browser>Preferences On 2017/03/14 23:43:45, Theresa wrote: > ...
3 years, 9 months ago (2017-03-14 23:53:07 UTC) #6
Theresa
lgtm
3 years, 9 months ago (2017-03-15 15:01:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745833002/40001
3 years, 9 months ago (2017-03-21 16:45:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/390400)
3 years, 9 months ago (2017-03-21 16:58:49 UTC) #13
Finnur
LGTM
3 years, 8 months ago (2017-03-31 09:51:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745833002/40001
3 years, 8 months ago (2017-03-31 13:50:32 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 14:02:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eedc8af55aa7e6fea5b8430c2534...

Powered by Google App Engine
This is Rietveld 408576698