Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2745813002: Revert of evaluating clipboard event target acording to w3c specification (Closed)

Created:
3 years, 9 months ago by luoe
Modified:
3 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of evaluating clipboard event target acording to w3c specification (patchset #7 id:120001 of https://codereview.chromium.org/2685723005/ ) Reason for revert: Changing this functionality improved spec conformance, but introduced regressions where text that used to be copied is no longer copied: crbug.com/695568 crbug.com/700163 A proposal to change the spec was made here: https://github.com/w3c/clipboard-apis/issues/40 Original issue's description: > Make Editor::findEventTargetFrom() to align Clipboard API specification > > This patch changes |Editor::findEventTargetFrom()| to return focused element if > selection start is not editable to align Clipboard API specification[1] for > improving interoperability. > > [1] https://w3c.github.io/clipboard-apis/#to-fire-a-clipboard-event > > BUG=690104 > TEST=webkit_unittests --gtest_filter=ClipboardEventFlowTest.* > > Review-Url: https://codereview.chromium.org/2685723005 > Cr-Commit-Position: refs/heads/master@{#451716} > Committed: https://chromium.googlesource.com/chromium/src/+/7afbab0f7619c89aa7a5896024d1628a59cc0ef1 TBR=tkent@chromium.org,ojan@chromium.org,yosin@chromium.org,yutak@chromium.org,sigbjornf@opera.com,mwrobel@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=690104 Review-Url: https://codereview.chromium.org/2745813002 Cr-Commit-Position: refs/heads/master@{#456232} Committed: https://chromium.googlesource.com/chromium/src/+/0b5fb5f6ef0d0deba7d706424cc3a05365172b1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -158 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-types.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/ClipboardEventFlowTest.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
luoe
Created Revert of evaluating clipboard event target acording to w3c specification
3 years, 9 months ago (2017-03-10 18:08:22 UTC) #1
luoe
Please take a look
3 years, 9 months ago (2017-03-11 00:17:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745813002/1
3 years, 9 months ago (2017-03-11 00:20:29 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-11 00:20:31 UTC) #15
lushnikov
lgtm
3 years, 9 months ago (2017-03-11 00:22:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745813002/1
3 years, 9 months ago (2017-03-11 00:22:43 UTC) #20
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:30:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b5fb5f6ef0d0deba7d706424cc3...

Powered by Google App Engine
This is Rietveld 408576698