android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java - Issue 2745803003: autofill-try

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 2745803003: autofill-try

Patch Set: before I leave Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_autofill_provider.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwAutofillManager.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

index 66779333e88e2b0175f4f0dcb441510308e16486..3ee0cc79d6ac743cca887b3d0aea17414df8757e 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

@@ -101,7 +101,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate

private final int mAppTargetSdkVersion;

- private WebViewChromiumFactoryProvider mFactory;

+ protected WebViewChromiumFactoryProvider mFactory;

private final boolean mShouldDisableThreadChecking;

@@ -249,7 +249,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate

"Calling View methods on another thread than the UI thread.");

}

- private boolean checkNeedsPost() {

+ protected boolean checkNeedsPost() {

boolean needsPost = !mFactory.hasStarted() || !ThreadUtils.runningOnUiThread();

if (!needsPost && mAwContents == null) {

throw new IllegalStateException("AwContents must be created if we are not posting!");