autofill-try

autofill-try

BUG=

[svetoslavganov, 2017-04-11 22:47:16]

svetoslavganov@google.com changed reviewers:
+ svetoslavganov@google.com

[svetoslavganov, 2017-04-11 22:47:17]

https://codereview.chromium.org/2745803003/diff/100001/android_webview/java/s...
File
android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java
(right):

https://codereview.chromium.org/2745803003/diff/100001/android_webview/java/s...
android_webview/java/src/org/chromium/android_webview/AwAutofillProvider.java:38:
public void fillViewStructure(ViewStructure structure) {
This children are not properly added which I suspect generates a malformed
assist structure leading to the crash. Should be something like this:

public void fillViewStructure(ViewStructure structure) {
    Log.e(TAG, "fillViewStructure " + mFormData.mFields.size());
    structure.setClassName(mFormData.mName);
    structure.setUrl(mFormData.mOrigin);
    final int childCount = mFormData.mFields.size();
    for (int i = 0; i < childCount; i++) {
        Filed field = mFormData.mFields.get(i);
        ViewStructure child = structure.newChild(i);
        child.setAutofillId(structure, toVirtualId(mClientId, fieldIndex++));
        // This is just for testing purpose, we should set ViewStructure
        // according new API.
        child.setAutofillValue(AutofillValue.forText(field.mName));
    }
}

[michaelbai, 2017-05-16 00:57:26]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 00:58:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 01:12:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 01:12:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelbai, 2017-05-16 01:54:15]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 01:54:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 02:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 02:01:03]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[michaelbai, 2017-05-16 03:12:44]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 03:13:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 04:10:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 04:11:00]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[michaelbai, 2017-05-16 04:25:47]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2017-05-16 04:25:49]

The CQ bit was unchecked by michaelbai@chromium.org

[michaelbai, 2017-05-16 04:25:56]

The CQ bit was unchecked by michaelbai@chromium.org

[michaelbai, 2017-05-16 04:26:04]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 04:26:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 05:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 05:30:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[michaelbai, 2017-05-16 05:58:59]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 05:59:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 06:11:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 06:11:27]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[michaelbai, 2017-05-16 07:36:22]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 07:36:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 08:22:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 08:22:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelbai, 2017-05-16 16:15:05]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 16:15:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 17:53:12]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[michaelbai, 2017-05-17 06:53:43]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 06:54:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 09:29:24]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[michaelbai, 2017-05-17 18:35:59]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 18:36:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 18:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 18:50:48]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[michaelbai, 2017-05-17 19:18:12]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 19:19:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:35:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:35:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[michaelbai, 2017-05-17 20:05:50]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:06:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 20:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:24:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelbai, 2017-05-17 20:30:13]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:31:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:34:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelbai, 2017-05-19 00:30:56]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 00:32:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:34:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:34:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[michaelbai, 2017-05-26 18:33:51]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 18:34:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 19:43:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 19:43:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelbai, 2017-05-26 21:02:15]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 21:03:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 23:07:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 23:07:38]

Dry run: This issue passed the CQ dry run.

[michaelbai, 2017-05-31 19:07:53]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 19:08:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 19:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:25:36]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[michaelbai, 2017-05-31 19:56:26]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 19:57:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:37:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:37:56]

Dry run: This issue passed the CQ dry run.