Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2745803002: Remove Wallet component-extension from chromium. (Closed)

Created:
3 years, 9 months ago by waffles
Modified:
3 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Wallet component-extension from chromium. BUG=700425 Review-Url: https://codereview.chromium.org/2745803002 Cr-Commit-Position: refs/heads/master@{#456426} Committed: https://chromium.googlesource.com/chromium/src/+/fb905f15c89bc2eb8358d899ec117f3d39258931

Patch Set 1 #

Patch Set 2 : Also remove unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
waffles
PTAL, thanks!
3 years, 9 months ago (2017-03-10 17:43:57 UTC) #4
Devlin
lgtm
3 years, 9 months ago (2017-03-11 03:09:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745803002/20001
3 years, 9 months ago (2017-03-13 17:23:15 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 18:09:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fb905f15c89bc2eb8358d899ec11...

Powered by Google App Engine
This is Rietveld 408576698