Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2745793004: Remove PaintInvalidatorContext::newVisualRect (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
pdr.
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PaintInvalidatorContext::newVisualRect Use LayoutObject::visualRect() instead. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2745793004 Cr-Commit-Position: refs/heads/master@{#456176} Committed: https://chromium.googlesource.com/chromium/src/+/cb0a2dd7de80140a3dcf0bfef6e44fa8bf80432c

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TablePaintInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Xianzhu
PaintInvalidator::newLocation is still kept because it's small and access ObjectPaintInvalidator::locationInBacking() has cost. We'll also eventually ...
3 years, 9 months ago (2017-03-10 19:48:36 UTC) #3
pdr.
On 2017/03/10 at 19:48:36, wangxianzhu wrote: > PaintInvalidator::newLocation is still kept because it's small and ...
3 years, 9 months ago (2017-03-10 20:31:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745793004/20001
3 years, 9 months ago (2017-03-10 20:36:21 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 21:52:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb0a2dd7de80140a3dcf0bfef6e4...

Powered by Google App Engine
This is Rietveld 408576698