Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 2745793002: Fix caret paint invalidation issues (Closed)

Created:
3 years, 9 months ago by Xianzhu
Modified:
3 years, 9 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Fix caret paint invalidation issues - We should save CaretDisplayItemClient::m_previousLayoutBlock only if it has not been saved since the last paint invalidation, because we use it to invalidate the caret in the layout block of the previous paint invalidation. - Caret painted output can change paint offset without visual rect change. Invalidate display item client if the block is doing full paint invalidation. BUG=699044, 698662 TBR=wangxianzhu@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2736213002 Cr-Commit-Position: refs/heads/master@{#455657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -68 lines) Patch
A third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/caret-change-paint-offset-keep-visual-expected.html View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/move-caret-in-container-change-paint-offset-keep-visual-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h View 2 chunks +10 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp View 4 chunks +39 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp View 7 chunks +16 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaret.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaret.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPaintInvalidator.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745793002/1
3 years, 9 months ago (2017-03-10 17:04:38 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 17:08:24 UTC) #5
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698