Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameCaret.h

Issue 2745793002: Fix caret paint invalidation issues (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 IntRect absoluteCaretBounds() const; 71 IntRect absoluteCaretBounds() const;
72 72
73 bool shouldShowBlockCursor() const { return m_shouldShowBlockCursor; } 73 bool shouldShowBlockCursor() const { return m_shouldShowBlockCursor; }
74 void setShouldShowBlockCursor(bool); 74 void setShouldShowBlockCursor(bool);
75 75
76 // Paint invalidation methods delegating to DisplayItemClient. 76 // Paint invalidation methods delegating to DisplayItemClient.
77 void clearPreviousVisualRect(const LayoutBlock&); 77 void clearPreviousVisualRect(const LayoutBlock&);
78 void layoutBlockWillBeDestroyed(const LayoutBlock&); 78 void layoutBlockWillBeDestroyed(const LayoutBlock&);
79 void updateStyleAndLayoutIfNeeded(); 79 void updateStyleAndLayoutIfNeeded();
80 void invalidatePaintIfNeeded(const LayoutBlock&, 80 void invalidatePaintIfNeeded(const LayoutBlock&,
81 const PaintInvalidatorContext&, 81 const PaintInvalidatorContext&);
82 PaintInvalidationReason);
83 82
84 bool shouldPaintCaret(const LayoutBlock&) const; 83 bool shouldPaintCaret(const LayoutBlock&) const;
85 void paintCaret(GraphicsContext&, const LayoutPoint&) const; 84 void paintCaret(GraphicsContext&, const LayoutPoint&) const;
86 85
87 // For unit tests. 86 // For unit tests.
88 const DisplayItemClient& caretDisplayItemClientForTesting() const; 87 const DisplayItemClient& caretDisplayItemClientForTesting() const;
89 const LayoutBlock* caretLayoutBlockForTesting() const; 88 const LayoutBlock* caretLayoutBlockForTesting() const;
90 bool shouldPaintCaretForTesting() const { return m_shouldPaintCaret; } 89 bool shouldPaintCaretForTesting() const { return m_shouldPaintCaret; }
91 void recreateCaretBlinkTimerForTesting(RefPtr<WebTaskRunner>); 90 void recreateCaretBlinkTimerForTesting(RefPtr<WebTaskRunner>);
92 91
(...skipping 18 matching lines...) Expand all
111 bool m_shouldPaintCaret : 1; 110 bool m_shouldPaintCaret : 1;
112 bool m_isCaretBlinkingSuspended : 1; 111 bool m_isCaretBlinkingSuspended : 1;
113 bool m_shouldShowBlockCursor : 1; 112 bool m_shouldShowBlockCursor : 1;
114 113
115 DISALLOW_COPY_AND_ASSIGN(FrameCaret); 114 DISALLOW_COPY_AND_ASSIGN(FrameCaret);
116 }; 115 };
117 116
118 } // namespace blink 117 } // namespace blink
119 118
120 #endif // FrameCaret_h 119 #endif // FrameCaret_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaret.cpp ('k') | third_party/WebKit/Source/core/editing/FrameCaret.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698