Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2745763002: [Merge-58] Update server card billing for already converted addresses (Closed)

Created:
3 years, 9 months ago by sebsg
Modified:
3 years, 9 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge-58] Update server card billing for already converted addresses Before this patch, if you added a new server card where the billing address was already converted (with an older card for example), the billing address id for the new card was not updated. With this patch, these cards will be updated too. For server cards with a billing address that was already converted, look for a local profile that matches it and update the id in the card BUG=698364 Review-Url: https://codereview.chromium.org/2734463004 Cr-Commit-Position: refs/heads/master@{#454976} (cherry picked from commit 1eeee730395362b15e304fa65fa36c5a0bc5e204) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2745763002 Cr-Commit-Position: refs/branch-heads/3029@{#110} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8aa2597c18b4dc96ca1fd2ab3311e7ce1084194c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -31 lines) Patch
M components/autofill/core/browser/personal_data_manager.h View 2 chunks +35 lines, -9 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 5 chunks +86 lines, -13 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 9 chunks +124 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sebsg
PTAL?
3 years, 9 months ago (2017-03-10 15:54:35 UTC) #2
Mathieu
if this is the same patch as in M59, lgtm
3 years, 9 months ago (2017-03-10 16:08:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745763002/1
3 years, 9 months ago (2017-03-10 16:11:08 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-10 16:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745763002/1
3 years, 9 months ago (2017-03-10 16:15:09 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 16:17:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8aa2597c18b4dc96ca1fd2ab3311...

Powered by Google App Engine
This is Rietveld 408576698