Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2745743002: Added BitsPerChannel method to video frame class. (Closed)

Created:
3 years, 9 months ago by Uzair
Modified:
3 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, cc-bugs_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added BitsPerChannel method to video frame class. This patch includes changes related to TODO where it was mentioned to add BitsPerChannel as a part of video frame class. Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>; CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2745743002 Cr-Commit-Position: refs/heads/master@{#457481} Committed: https://chromium.googlesource.com/chromium/src/+/97ea0f4cf155818e36cc00338e2645881ee0ba02

Patch Set 1 #

Patch Set 2 : Added BitsPerChannel method to video frame class. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 chunk +1 line, -44 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
Uzair
On 2017/03/10 08:43:44, Uzair wrote: > mailto:uzair.jaleel@samsung.com changed reviewers: > + mailto:hubbe@chromium.org Dear Reviewers, PTAL. ...
3 years, 9 months ago (2017-03-10 08:44:46 UTC) #4
Uzair
On 2017/03/10 08:44:46, Uzair wrote: > On 2017/03/10 08:43:44, Uzair wrote: > > mailto:uzair.jaleel@samsung.com changed ...
3 years, 9 months ago (2017-03-14 04:23:02 UTC) #5
hubbe
lgtm
3 years, 9 months ago (2017-03-14 05:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745743002/20001
3 years, 9 months ago (2017-03-14 06:02:38 UTC) #9
commit-bot: I haz the power
The author uzair.jaleel@samsung.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 9 months ago (2017-03-14 06:02:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745743002/20001
3 years, 9 months ago (2017-03-15 03:10:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/385768)
3 years, 9 months ago (2017-03-15 03:19:28 UTC) #15
Uzair
On 2017/03/15 03:19:28, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 9 months ago (2017-03-15 07:44:16 UTC) #17
Uzair
On 2017/03/15 07:44:16, Uzair wrote: > On 2017/03/15 03:19:28, commit-bot: I haz the power wrote: ...
3 years, 9 months ago (2017-03-16 06:34:24 UTC) #18
suchit.agrawal
3 years, 9 months ago (2017-03-16 11:55:14 UTC) #20
danakj
cc LGTM
3 years, 9 months ago (2017-03-16 15:35:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745743002/20001
3 years, 9 months ago (2017-03-16 16:13:31 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:44:03 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97ea0f4cf155818e36cc00338e26...

Powered by Google App Engine
This is Rietveld 408576698