Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2745733004: Options: fix "Manage extension" link in controlled-by-extension bubbles (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Options: fix "Manage extension" link in controlled-by-extension bubbles R=rdevlin.cronin@chromium.org BUG=700312 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2745733004 Cr-Commit-Position: refs/heads/master@{#456239} Committed: https://chromium.googlesource.com/chromium/src/+/e1d64e748a34ba84f739207b74a3bba8a6c4b6af

Patch Set 1 #

Patch Set 2 : window.open() instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/options/controlled_setting.js View 1 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Devlin
lgtm
3 years, 9 months ago (2017-03-10 23:07:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745733004/20001
3 years, 9 months ago (2017-03-10 23:09:26 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 00:53:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1d64e748a34ba84f739207b74a3...

Powered by Google App Engine
This is Rietveld 408576698