chromeos: Fix shutdown crash in status area teardown on stylus devices

chromeos: Fix shutdown crash in status area teardown on stylus devices

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I added a DCHECK to ensure all views are being cleaned up and filed a bug
to refactor this code so we don't have to clean up the views manually.

Fixed FocusCycleTest so it doesn't add duplicate child views to the status
area, which was tripping my DCHECK.

BUG=700122
Review-Url: https://codereview.chromium.org/2745723002
Cr-Commit-Position: refs/heads/master@{#456104}
Committed: https://chromium.googlesource.com/chromium/src/+/fe89c29e259964557dc8a1ff4e450accb47193e1

[James Cook, 2017-03-10 05:49:42]

Description was changed from

==========
chromeos: Fix shutdown crash in status area teardown on stylus devices

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I also added a DCHECK to ensure all views are being cleaned up and filed a
bug to refactor this code so we don't have to clean up the views manually.

BUG=700122
==========

to

==========
chromeos: Fix shutdown crash in status area teardown on stylus devices

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I added a DCHECK to ensure all views are being cleaned up and filed a bug
to refactor this code so we don't have to clean up the views manually.

Fixed FocusCycleTest so it doesn't add duplicate child views to the status
area, which was tripping my DCHECK.

BUG=700122
==========

[James Cook, 2017-03-10 05:51:22]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 05:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-03-10 05:53:02]

jamescook@chromium.org changed reviewers:
+ jdufault@chromium.org

[James Cook, 2017-03-10 05:53:03]

jdufault, please take a look. If it looks good to you please CQ -- the bug is a
release blocker and I'm OOO tomorrow morning.

https://codereview.chromium.org/2745723002/diff/20001/ash/focus_cycler_unitte...
File ash/focus_cycler_unittest.cc (left):

https://codereview.chromium.org/2745723002/diff/20001/ash/focus_cycler_unitte...
ash/focus_cycler_unittest.cc:87: widget->Show();
This isn't needed either, the widget is visible by default.

[commit-bot: I haz the power, 2017-03-10 06:21:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 06:21:21]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-03-10 15:13:50]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 15:13:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 15:44:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 15:44:50]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-10 17:51:05]

thanks, lgtm

[jdufault, 2017-03-10 17:51:13]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:51:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:03:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489168273363120,
"parent_rev": "9d7a165ce1c347e2b9a2ff253421d30c5d03ba5c", "commit_rev":
"fe89c29e259964557dc8a1ff4e450accb47193e1"}

[commit-bot: I haz the power, 2017-03-10 18:04:11]

Description was changed from

==========
chromeos: Fix shutdown crash in status area teardown on stylus devices

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I added a DCHECK to ensure all views are being cleaned up and filed a bug
to refactor this code so we don't have to clean up the views manually.

Fixed FocusCycleTest so it doesn't add duplicate child views to the status
area, which was tripping my DCHECK.

BUG=700122
==========

to

==========
chromeos: Fix shutdown crash in status area teardown on stylus devices

StatusAreaWidget::Shutdown() needs to manually remove all its child view to
avoid layout problems during shutdown. The stylus palette tray view wasn't
being removed.

This should fix a crash in aura::WindowEventDispatcher::ReleaseNativeCapture
during ash::Shell teardown that we're seeing on kevin.

I added a DCHECK to ensure all views are being cleaned up and filed a bug
to refactor this code so we don't have to clean up the views manually.

Fixed FocusCycleTest so it doesn't add duplicate child views to the status
area, which was tripping my DCHECK.

BUG=700122

Review-Url: https://codereview.chromium.org/2745723002
Cr-Commit-Position: refs/heads/master@{#456104}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe89c29e259964557dc8a1ff4e45...
==========

[commit-bot: I haz the power, 2017-03-10 18:04:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fe89c29e259964557dc8a1ff4e45...