Run gtest based test suites that are affected by PlzNavigate on the Android waterfall.

Run gtest based test suites that are affected by PlzNavigate on the Android waterfall.

These are:
components_browsertests
components_unittests
content_browsertests
content_unittests
unit_tests

Marshmallow 64 bit bot is used since it's not on the CQ, as we don't have capacity yet to enable this on the main waterfall. Also OS specific breakages should be rare.

In a followup we'll add some instrumentation test suites when support for passing command lines is available.

BUG=699242
Review-Url: https://codereview.chromium.org/2745683002
Cr-Commit-Position: refs/heads/master@{#456103}
Committed: https://chromium.googlesource.com/chromium/src/+/9d7a165ce1c347e2b9a2ff253421d30c5d03ba5c

[jam, 2017-03-10 04:28:26]

jam@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2017-03-10 06:13:58]

lgtm

From scanning through the logs, it looks like --test-arguments is behaving as
intended. The browser_side_navigation_content_browsertests that failed appear to
have done so due to https://codereview.chromium.org/2509103002/.

[jbudorick, 2017-03-10 14:14:31]

https://codereview.chromium.org/2745683002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2745683002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:2790:
"--test-arguments='--enable-browser-side-navigation'"
actually, on second look, let me investigate how the quoting behaves before you
commit this. We're sending

  am instrument ... -e "$p".NativeTest.CommandLineFlags
''"'"'--enable-browser-side-navigation'"'"''

and I want to make sure that that's working as expected, particularly w.r.t. the
quotes.

[jbudorick, 2017-03-10 15:18:46]

https://codereview.chromium.org/2745683002/diff/20001/testing/buildbot/chromi...
File testing/buildbot/chromium.android.json (right):

https://codereview.chromium.org/2745683002/diff/20001/testing/buildbot/chromi...
testing/buildbot/chromium.android.json:2790:
"--test-arguments='--enable-browser-side-navigation'"
On 2017/03/10 14:14:31, jbudorick wrote:
> actually, on second look, let me investigate how the quoting behaves before
you
> commit this. We're sending
> 
>   am instrument ... -e "$p".NativeTest.CommandLineFlags
> ''"'"'--enable-browser-side-navigation'"'"''
> 
> and I want to make sure that that's working as expected, particularly w.r.t.
the
> quotes.

yeah, it appears that the quotes don't quite work as intended.
--test-arguments=--enable-browser-side-navigation should work, though.

[jam, 2017-03-10 15:57:11]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-03-10 15:57:20]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-03-10 15:57:42]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-03-10 15:57:50]

ptal

[commit-bot: I haz the power, 2017-03-10 15:58:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbudorick, 2017-03-10 16:25:22]

lgtm

[jam, 2017-03-10 16:48:18]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-03-10 16:48:22]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:48:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:01:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489164502703850,
"parent_rev": "911ea3c964671fb131a49c7be4225a30ea9468e2", "commit_rev":
"9d7a165ce1c347e2b9a2ff253421d30c5d03ba5c"}

[commit-bot: I haz the power, 2017-03-10 18:01:52]

Description was changed from

==========
Run gtest based test suites that are affected by PlzNavigate on the Android
waterfall.

These are:
components_browsertests
components_unittests
content_browsertests
content_unittests
unit_tests

Marshmallow 64 bit bot is used since it's not on the CQ, as we don't have
capacity yet to enable this on the main waterfall. Also OS specific breakages
should be rare.

In a followup we'll add some instrumentation test suites when support for
passing command lines is available.

BUG=699242
==========

to

==========
Run gtest based test suites that are affected by PlzNavigate on the Android
waterfall.

These are:
components_browsertests
components_unittests
content_browsertests
content_unittests
unit_tests

Marshmallow 64 bit bot is used since it's not on the CQ, as we don't have
capacity yet to enable this on the main waterfall. Also OS specific breakages
should be rare.

In a followup we'll add some instrumentation test suites when support for
passing command lines is available.

BUG=699242

Review-Url: https://codereview.chromium.org/2745683002
Cr-Commit-Position: refs/heads/master@{#456103}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d7a165ce1c347e2b9a2ff253421...
==========

[commit-bot: I haz the power, 2017-03-10 18:01:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d7a165ce1c347e2b9a2ff253421...