Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2745673002: Add Java wrapper for RenderFrameHost (Closed)

Created:
3 years, 9 months ago by rwlbuis
Modified:
3 years, 9 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Java wrapper for RenderFrameHost This patch adds a Java wrapper for RenderFrameHost. It also adds a getMainFrame method to WebContents. This will be useful for Payment Request which needs to know the exact (sub)frame issued the payment request. BUG=620173 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -3 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A content/browser/frame_host/render_frame_host_android.h View 1 chunk +50 lines, -0 lines 0 comments Download
A content/browser/frame_host/render_frame_host_android.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +20 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostDelegate.java View 1 chunk +11 lines, -0 lines 0 comments Download
A content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java View 1 chunk +49 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 6 chunks +23 lines, -2 lines 0 comments Download
A content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java View 1 chunk +18 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/webcontents/WebContentsTest.java View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
rwlbuis
PTAL.
3 years, 9 months ago (2017-03-09 23:33:08 UTC) #3
boliu
3 years, 9 months ago (2017-03-09 23:34:30 UTC) #4
On 2017/03/09 23:33:08, rwlbuis wrote:
> PTAL.

You can just re-open the old code review? Or if you do use a new one, upload the
original CL as a patch set, then another patch set with additional changes, so I
don't have to look over everything again.

Powered by Google App Engine
This is Rietveld 408576698