[net] Add a typemap for net::IPAddress

[net] Add a typemap for net::IPAddress

To resolve code review comments from https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/router/mojo/media_router.mojom

Create an ip_address.mojom to be used by media_router.mojom

BUG=698423
Review-Url: https://codereview.chromium.org/2745643002
Cr-Commit-Position: refs/heads/master@{#456115}
Committed: https://chromium.googlesource.com/chromium/src/+/d81b759bf2a2fc62238efe3f01eb5faa74f2d374

[zhaobin, 2017-03-09 22:05:36]

zhaobin@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-03-09 22:11:36]

https://codereview.chromium.org/2745643002/diff/1/net/interfaces/ip_address_s...
File net/interfaces/ip_address_struct_traits.cc (right):

https://codereview.chromium.org/2745643002/diff/1/net/interfaces/ip_address_s...
net/interfaces/ip_address_struct_traits.cc:17: return true;
Should we check out->IsValid() here?

[zhaobin, 2017-03-09 22:21:05]

https://codereview.chromium.org/2745643002/diff/1/net/interfaces/ip_address_s...
File net/interfaces/ip_address_struct_traits.cc (right):

https://codereview.chromium.org/2745643002/diff/1/net/interfaces/ip_address_s...
net/interfaces/ip_address_struct_traits.cc:17: return true;
On 2017/03/09 22:11:35, dcheng wrote:
> Should we check out->IsValid() here?

Done.

[dcheng, 2017-03-09 22:22:26]

https://codereview.chromium.org/2745643002/diff/20001/net/interfaces/BUILD.gn
File net/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2745643002/diff/20001/net/interfaces/BUILD.gn...
net/interfaces/BUILD.gn:19: "ip_address.mojom",
Nit: group this into the interfaces target

[dcheng, 2017-03-09 22:22:34]

(Also, LGTM)

[zhaobin, 2017-03-09 22:35:01]

https://codereview.chromium.org/2745643002/diff/20001/net/interfaces/BUILD.gn
File net/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2745643002/diff/20001/net/interfaces/BUILD.gn...
net/interfaces/BUILD.gn:19: "ip_address.mojom",
On 2017/03/09 22:22:26, dcheng wrote:
> Nit: group this into the interfaces target

Done.

[zhaobin, 2017-03-09 22:35:23]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 22:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 22:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 22:42:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zhaobin, 2017-03-09 23:12:47]

zhaobin@chromium.org changed reviewers:
+ rsleevi@chromium.org

[zhaobin, 2017-03-09 23:12:48]

+rsleevi@ for net/interfaces/ changes:

net/interfaces/BUILD.gn
net/interfaces/OWNERS
net/interfaces/typemaps.gni

[Ryan Sleevi, 2017-03-09 23:54:07]

rsleevi@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Ryan Sleevi, 2017-03-09 23:54:07]

I'm largely rubberstamp LGTMing this on dcheng's review - dcheng, if you didn't
mean for that to happen, yell now.

Can you point to documentation about typemaps and the proper use? I don't feel
qualified to review this CL because of that, and that's no bueno - so please
provide documentation (and if there isn't any, it needs to be written) about
these generators and code.

Also, feel free to send future Mojo-related changes to rdsmith (cc'd), since
he's trying to do a lot of that for //net :)

[Ryan Sleevi, 2017-03-09 23:54:33]

To make the gatekeeper happy - LGTM

[zhaobin, 2017-03-10 00:50:26]

On 2017/03/09 23:54:07, Ryan Sleevi wrote:
> I'm largely rubberstamp LGTMing this on dcheng's review - dcheng, if you
didn't
> mean for that to happen, yell now.
> 
> Can you point to documentation about typemaps and the proper use? I don't feel
> qualified to review this CL because of that, and that's no bueno - so please
> provide documentation (and if there isn't any, it needs to be written) about
> these generators and code.
> 
> Also, feel free to send future Mojo-related changes to rdsmith (cc'd), since
> he's trying to do a lot of that for //net :)

Doc for type mapping:
https://www.chromium.org/developers/design-documents/mojo/type-mapping

Thanks a lot for looking at this :) I am not familiar with //net and trying to
fix presubmit errors...

[zhaobin, 2017-03-10 01:43:49]

The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 01:44:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:48:19]

Dry run: This issue passed the CQ dry run.

[zhaobin, 2017-03-10 18:31:28]

The CQ bit was checked by zhaobin@chromium.org

[zhaobin, 2017-03-10 18:31:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2745643002/#ps60001
(title: "update net/interfaces/OWNERS")

[commit-bot: I haz the power, 2017-03-10 18:31:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:38:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489170688506030,
"parent_rev": "70482db41f51d5b774b59bfaeb1bd1953d0884a4", "commit_rev":
"d81b759bf2a2fc62238efe3f01eb5faa74f2d374"}

[commit-bot: I haz the power, 2017-03-10 18:39:20]

Description was changed from

==========
[net] Add a typemap for net::IPAddress

To resolve code review comments from
https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/r...

Create an ip_address.mojom to be used by media_router.mojom

BUG=698423
==========

to

==========
[net] Add a typemap for net::IPAddress

To resolve code review comments from
https://codereview.chromium.org/2675033002/diff/280001/chrome/browser/media/r...

Create an ip_address.mojom to be used by media_router.mojom

BUG=698423

Review-Url: https://codereview.chromium.org/2745643002
Cr-Commit-Position: refs/heads/master@{#456115}
Committed:
https://chromium.googlesource.com/chromium/src/+/d81b759bf2a2fc62238efe3f01eb...
==========

[commit-bot: I haz the power, 2017-03-10 18:39:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d81b759bf2a2fc62238efe3f01eb...