Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2745583005: Image Capture: move files out of content/browser/media/capture to replicate WebKit's structure (Closed)

Created:
3 years, 9 months ago by mcasas
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit), miu
CC:
chromium-reviews, creis+watch_chromium.org, chfremer+watch_chromium.org, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: move files out of content/browser/media/capture to replicate WebKit's structure No new code, just shuffling things around so WebKit/Source/modules and content/browser have a more related structure, also in terms of bug components and OWNERS. BUG=none (no new code) Review-Url: https://codereview.chromium.org/2745583005 Cr-Commit-Position: refs/heads/master@{#456198} Committed: https://chromium.googlesource.com/chromium/src/+/18de5022a2a0a25b86c2919783426a9276728e56

Patch Set 1 #

Patch Set 2 : Reverted unintended change to WATCHLISTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -225 lines) Patch
M content/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A content/browser/image_capture/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
A + content/browser/image_capture/image_capture_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/image_capture/image_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/media/capture/image_capture_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/media/capture/image_capture_impl.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
mcasas
miu@ RS plz (moving files around).
3 years, 9 months ago (2017-03-10 03:32:22 UTC) #2
mcasas
avi@ RS plz
3 years, 9 months ago (2017-03-10 18:04:24 UTC) #4
Avi (use Gerrit)
move lgtm
3 years, 9 months ago (2017-03-10 18:28:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745583005/40001
3 years, 9 months ago (2017-03-10 22:34:08 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 22:46:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18de5022a2a0a25b86c291978342...

Powered by Google App Engine
This is Rietveld 408576698