Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2745583002: Deal with bad supertypes. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deal with bad supertypes when installing default constructors. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/5b8d5a12f5fa8057f8aa2127cd57e4d1809dfd1b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update status files. #

Patch Set 3 : Change URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
ahe
3 years, 9 months ago (2017-03-09 14:24:07 UTC) #2
karlklose
LGTM The CL title could be more specific (like 'Deal with bad supertypes when installing ...
3 years, 9 months ago (2017-03-10 05:36:46 UTC) #3
ahe
On 2017/03/10 05:36:46, karlklose wrote: > The CL title could be more specific (like 'Deal ...
3 years, 9 months ago (2017-03-10 05:54:06 UTC) #5
ahe
https://codereview.chromium.org/2745583002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart File pkg/front_end/lib/src/fasta/kernel/kernel_target.dart (right): https://codereview.chromium.org/2745583002/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_target.dart#newcode409 pkg/front_end/lib/src/fasta/kernel/kernel_target.dart:409: /// http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-408.pdf): On 2017/03/10 05:36:46, karlklose wrote: > BTW: ...
3 years, 9 months ago (2017-03-10 07:38:17 UTC) #6
ahe
3 years, 9 months ago (2017-03-10 07:44:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
5b8d5a12f5fa8057f8aa2127cd57e4d1809dfd1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698