Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2741753002: Handle bad factory names correctly. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 1 chunk +4 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-09 15:18:43 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-10 05:50:29 UTC) #3
ahe
3 years, 9 months ago (2017-03-10 08:07:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a1c29b1fb3cb529f9fbc87ddea10cba5f86374e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698