Show notification during ARC managed provision

chrome/browser/chromeos/arc/arc_session_manager.h

Index: chrome/browser/chromeos/arc/arc_session_manager.h
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.h b/chrome/browser/chromeos/arc/arc_session_manager.h
index 1f23796bd658fec2b60fe15f2af47d4bd0373831..9199ff9356ef8503183d5426b249377b592c57da 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.h
+++ b/chrome/browser/chromeos/arc/arc_session_manager.h
@@ -94,6 +94,10 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
     // is represented by "arc.enabled" preference, is updated.
     virtual void OnArcPlayStoreEnabledChanged(bool enabled) {}
 
+    // Called to notify that checking of Android management status started
+    // during OptIn flow.
+    virtual void OnArcStartOptInAndroidManagementCheck() {}

[Luis Héctor Chávez, 2017/03/13 15:50:41]

nit: Events should be OnArc[Phrase][Verb in past participle](), so this should
be called OnArcAndroidOptInManagementCheckStarted() (or
OnArcOptInManagementCheckStarted(), not sure how important it is to mention the
"Android" part).

[emaxx, 2017/03/16 18:32:12]

Done.

+
     // Called to notify that ARC has been initialized successfully.
     virtual void OnArcInitialStart() {}
 
@@ -105,6 +109,10 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
     // browser_tests
     virtual void OnArcDataRemoved() {}
 
+    // Called to notify that the error is requested to be displayed in the

[hidehiko, 2017/03/13 05:10:46]

ARC support app can switch to an error page by itself (e.g., failing to fetch
the ToS webpage), and this callback is not notified then.

As long as this addresses your concern, I'm ok to add this in short term, but
could you document it explicitly with TODO?

[emaxx, 2017/03/16 18:32:12]

Done. Tried to address this by the name of the method and a note in the comment.

+    // support host.
+    virtual void OnArcSupportHostErrorShown(ArcSupportHost::Error error) {}
+
    protected:
     virtual ~Observer() = default;
   };
@@ -299,6 +307,11 @@ class ArcSessionManager : public ArcSessionRunner::Observer,
   // is fixed.
   void MaybeReenableArc();
 
+  // Requests the support host (if it exists) to show the error, and notifies
+  // the observers.
+  void ShowArcSupportHostError(ArcSupportHost::Error error,
+                               bool should_show_send_feedback);
+
   std::unique_ptr<ArcSessionRunner> arc_session_runner_;
 
   // Unowned pointer. Keeps current profile.