Show notification during ARC managed provision

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 76 matching lines @@
     ACTIVE,
   };
 
   // Observer for those services outside of ARC which want to know ARC events.
   class Observer {
    public:
     // Called to notify that whether Google Play Store is enabled or not, which
     // is represented by "arc.enabled" preference, is updated.
     virtual void OnArcPlayStoreEnabledChanged(bool enabled) {}
 
+    // Called to notify that checking of Android management status started
+    // during OptIn flow.
+    virtual void OnArcStartOptInAndroidManagementCheck() {}

[Luis Héctor Chávez, 2017/03/13 15:50:41]

nit: Events should be OnArc[Phrase][Verb in past participle](), so this should
be called OnArcAndroidOptInManagementCheckStarted() (or
OnArcOptInManagementCheckStarted(), not sure how important it is to mention the
"Android" part).

[emaxx, 2017/03/16 18:32:12]

Done.

+
     // Called to notify that ARC has been initialized successfully.
     virtual void OnArcInitialStart() {}
 
     // Called when ARC session is stopped, and is not being restarted
     // automatically.
     virtual void OnArcSessionStopped(ArcStopReason stop_reason) {}
 
     // Called to notify that Android data has been removed. Used in
     // browser_tests
     virtual void OnArcDataRemoved() {}
 
+    // Called to notify that the error is requested to be displayed in the

[hidehiko, 2017/03/13 05:10:46]

ARC support app can switch to an error page by itself (e.g., failing to fetch
the ToS webpage), and this callback is not notified then.

As long as this addresses your concern, I'm ok to add this in short term, but
could you document it explicitly with TODO?

[emaxx, 2017/03/16 18:32:12]

Done. Tried to address this by the name of the method and a note in the comment.

+    // support host.
+    virtual void OnArcSupportHostErrorShown(ArcSupportHost::Error error) {}
+
    protected:
     virtual ~Observer() = default;
   };
 
   explicit ArcSessionManager(
       std::unique_ptr<ArcSessionRunner> arc_session_runner);
   ~ArcSessionManager() override;
 
   static ArcSessionManager* Get();
 
@@ skipping 174 matching lines @@
   // MaybeReenableArc() directly.
   void MaybeStartArcDataRemoval();
   void OnArcDataRemoved(bool success);
 
   // On ARC session stopped and/or data removal completion, this is called
   // so that, if necessary, ARC session is restarted.
   // TODO(hidehiko): This can be removed after the racy state machine
   // is fixed.
   void MaybeReenableArc();
 
+  // Requests the support host (if it exists) to show the error, and notifies
+  // the observers.
+  void ShowArcSupportHostError(ArcSupportHost::Error error,
+                               bool should_show_send_feedback);
+
   std::unique_ptr<ArcSessionRunner> arc_session_runner_;
 
   // Unowned pointer. Keeps current profile.
   Profile* profile_ = nullptr;
 
   // Whether ArcSessionManager is requested to enable (starting to run ARC
   // instance) or not.
   bool enable_requested_ = false;
 
   // Internal state machine. See also State enum class.
@@ skipping 23 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_