Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2745533004: Range.surroundContents() should not check node types beforehand. (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Range.surroundContents() should not check node types beforehand. Our implementation checked childTypeAllowed() beforehand. However, this is not defined by the DOM standard, and caused some test failures. This CL removes it. Also, this CL corrects the order of step 3 and step 4 because the above removal regressed some passing tests, and the order correction recovers them. BUG=700266 Review-Url: https://codereview.chromium.org/2745533004 Cr-Commit-Position: refs/heads/master@{#456017} Committed: https://chromium.googlesource.com/chromium/src/+/caf3c3acbe69ac013e2aaafad5c8110bb66e435a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/ranges/Range-surroundContents-expected.txt View 2 chunks +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 2 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tkent
yosin@, would you review this please? This fixes 24 tests.
3 years, 9 months ago (2017-03-10 06:29:22 UTC) #9
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-10 07:23:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745533004/1
3 years, 9 months ago (2017-03-10 07:23:48 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:27:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/caf3c3acbe69ac013e2aaafad5c8...

Powered by Google App Engine
This is Rietveld 408576698