Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2745433003: Remove some dated Member friendships. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some dated Member friendships. CollectionBackingTraceTrait no longer exists, and Visitor only needs to be friend with WeakMember<>. R= BUG= Review-Url: https://codereview.chromium.org/2745433003 Cr-Commit-Position: refs/heads/master@{#455786} Committed: https://chromium.googlesource.com/chromium/src/+/aa3f4d5c4ade03f9abc1989c2f03f025fb692ec0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M third_party/WebKit/Source/platform/heap/Member.h View 3 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look, a detail noticed.
3 years, 9 months ago (2017-03-09 15:03:41 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-09 15:10:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745433003/1
3 years, 9 months ago (2017-03-09 16:18:12 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 17:47:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa3f4d5c4ade03f9abc1989c2f03...

Powered by Google App Engine
This is Rietveld 408576698