Issue 2745433002: PreloadCheckGroup for managing multiple extension PreloadChecks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2745433002: PreloadCheckGroup for managing multiple extension PreloadChecks (Closed)

Created:
3 years, 9 months ago by michaelpg

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

PreloadCheckGroup for managing multiple extension PreloadChecks Has some commented-out code at the moment. BUG= COMMIT=false

Patch Set 1 #

Patch Set 2 : rebase & updates #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+386 lines, -9 lines)			Patch
M	extensions/browser/BUILD.gn	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
A	extensions/browser/preload_check_group.h	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
A	extensions/browser/preload_check_group.cc	View	1	1 chunk	+85 lines, -0 lines	0 comments	Download
A	extensions/browser/preload_check_group_unittest.cc	View	1	1 chunk	+209 lines, -0 lines	0 comments	Download
M	extensions/browser/preload_check_test_util.h	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	extensions/browser/preload_check_test_util.cc	View	1	4 chunks	+14 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 2737053002 Patch 80001

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

michaelpg

Description was changed from ========== PreloadCheckGroup for managing multiple extension PreloadChecks BUG= COMMIT=false ========== to ...

3 years, 9 months ago (2017-03-10 09:12:01 UTC) #1

michaelpg

3 years, 9 months ago (2017-03-18 01:46:18 UTC) #2

Description was changed from

==========
PreloadCheckGroup for managing multiple extension PreloadChecks

Not ready for review, here as an FYI.

BUG=
COMMIT=false
==========

to

==========
PreloadCheckGroup for managing multiple extension PreloadChecks

Has some commented-out code at the moment.

BUG=
COMMIT=false
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages