Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2737053002: Update ExtensionInstallChecker to use PreloadCheck classes (Closed)

Created:
3 years, 9 months ago by michaelpg
Modified:
3 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ExtensionInstallChecker to use PreloadCheck classes Replaces some ad-hoc checks with their encapsulated equivalents. Later, the individual OnFooCheckDone methods will be eliminated too. CLOSED for this version: https://codereview.chromium.org/2768723002 BUG=679971 COMMIT=false

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Rebase on simplified ExtensionInstallChecker #

Patch Set 4 : rebase #

Patch Set 5 : rebase on enable_extensions=0 fix #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -83 lines) Patch
M chrome/browser/extensions/crx_installer.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker.h View 1 2 3 4 5 3 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker.cc View 1 2 3 4 5 6 chunks +29 lines, -21 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker_unittest.cc View 1 2 3 4 5 9 chunks +55 lines, -45 lines 0 comments Download
M extensions/browser/preload_check_test_util.h View 1 2 3 2 chunks +25 lines, -0 lines 0 comments Download
M extensions/browser/preload_check_test_util.cc View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2751013002 Patch 80001

Messages

Total messages: 4 (4 generated)
michaelpg
Description was changed from ========== Update ExtensionInstallChecker to use PreloadCheck classes Replaces some ad-hoc checks ...
3 years, 9 months ago (2017-03-10 23:35:42 UTC) #1
michaelpg
michaelpg@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
3 years, 9 months ago (2017-03-10 23:35:42 UTC) #2
michaelpg
Description was changed from ========== Update ExtensionInstallChecker to use PreloadCheck classes Replaces some ad-hoc checks ...
3 years, 9 months ago (2017-03-22 00:37:11 UTC) #3
michaelpg
3 years, 9 months ago (2017-03-22 00:37:50 UTC) #4
Message was sent while issue was closed. 
Description was changed from

==========
Update ExtensionInstallChecker to use PreloadCheck classes

Replaces some ad-hoc checks with their encapsulated equivalents.

Later, the individual OnFooCheckDone methods will be eliminated too.

CLOSED for this version: https://codereview.chromium.org/2751013002/#ps100001

BUG=679971
COMMIT=false
==========

to

==========
Update ExtensionInstallChecker to use PreloadCheck classes

Replaces some ad-hoc checks with their encapsulated equivalents.

Later, the individual OnFooCheckDone methods will be eliminated too.

CLOSED for this version: https://codereview.chromium.org/2768723002

BUG=679971
COMMIT=false
==========

Powered by Google App Engine
This is Rietveld 408576698