Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2745413003: Do not auto-open histograms in singular rows. (Closed)

Created:
3 years, 9 months ago by benjhayden
Modified:
3 years, 9 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Do not auto-open histograms in singular rows. Currently, if there is only a single row, histogram-set-table automatically opens its Histograms. This is a UX optimization: we expect users to decide which cells to open and then click them, so if we know which cells they will want to open (because there are so few of them to choose from), then we don't have to wait for them to pick and click, we can just go ahead and automatically open them. In practice, most metrics produce more than one Histogram, so the single-row situation only arises in blink_perf.dom tests. Recent feedback has called into question the value of automatically overloading the user with the full contents of every Histogram, so this CL removes this UX optimization. Review-Url: https://codereview.chromium.org/2745413003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0a929d3695a1baaa4a97ca6548e83f55ead6ce22

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M tracing/tracing/value/ui/histogram_set_table.html View 2 chunks +0 lines, -12 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_test.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
benjhayden
PTAL
3 years, 9 months ago (2017-03-14 21:59:57 UTC) #2
eakuefner
lgtm
3 years, 9 months ago (2017-03-14 22:02:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745413003/20001
3 years, 9 months ago (2017-03-15 03:12:26 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 03:34:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698