MD Settings: announce search results

MD Settings: announce search results

R=dpapad@chromium.org
BUG=693376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745383002
Cr-Commit-Position: refs/heads/master@{#456793}
Committed: https://chromium.googlesource.com/chromium/src/+/5619e9d02fca745e028c5094b4dc977bd7b6298d

[Dan Beam, 2017-03-14 03:21:07]

Description was changed from

==========
MD Settings: announce search results

R=dpapad@chromium.org
BUG=693376
==========

to

==========
MD Settings: announce search results

R=dpapad@chromium.org
BUG=693376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-14 03:23:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-03-14 03:23:45]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 03:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 04:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 04:29:49]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-03-14 17:07:09]

LGTM with question.

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:267:
this.inSearchMode_ = !request.isSame('');
Need to rebase this, after
https://codereview.chromium.org/2739323005/diff/120001/chrome/browser/resourc....

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:273:
this.fire('iron-announce', {
Do you also need { bubbles: true }, per the example at
https://www.webcomponents.org/element/PolymerElements/iron-a11y-announcer?

[Dan Beam, 2017-03-14 18:14:37]

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:267:
this.inSearchMode_ = !request.isSame('');
On 2017/03/14 17:07:09, dpapad wrote:
> Need to rebase this, after
>
https://codereview.chromium.org/2739323005/diff/120001/chrome/browser/resourc....

Done.

https://codereview.chromium.org/2745383002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:273:
this.fire('iron-announce', {
On 2017/03/14 17:07:09, dpapad wrote:
> Do you also need { bubbles: true }, per the example at
> https://www.webcomponents.org/element/PolymerElements/iron-a11y-announcer

no, it works without it

[Dan Beam, 2017-03-14 18:14:41]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-14 18:14:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2745383002/#ps40001
(title: "dpapad@ review")

[commit-bot: I haz the power, 2017-03-14 18:15:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 19:47:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489515281161830,
"parent_rev": "d79748231089bb3931dce5ac1afd46fc53a5fb0c", "commit_rev":
"5619e9d02fca745e028c5094b4dc977bd7b6298d"}

[commit-bot: I haz the power, 2017-03-14 19:47:48]

Description was changed from

==========
MD Settings: announce search results

R=dpapad@chromium.org
BUG=693376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: announce search results

R=dpapad@chromium.org
BUG=693376
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745383002
Cr-Commit-Position: refs/heads/master@{#456793}
Committed:
https://chromium.googlesource.com/chromium/src/+/5619e9d02fca745e028c5094b4dc...
==========

[commit-bot: I haz the power, 2017-03-14 19:47:49]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5619e9d02fca745e028c5094b4dc...