Chromium Code Reviews
DescriptionRevert of evaluating clipboard event target acording to w3c specification (patchset #7 id:120001 of https://codereview.chromium.org/2685723005/ )
Reason for revert:
Changing this functionality improved spec conformance, but introduced regressions where text that used to be copied is no longer copied:
crbug.com/695568
crbug.com/700163
A proposal to change the spec was made here:
https://github.com/w3c/clipboard-apis/issues/40
Original issue's description:
> Make Editor::findEventTargetFrom() to align Clipboard API specification
>
> This patch changes |Editor::findEventTargetFrom()| to return focused element if
> selection start is not editable to align Clipboard API specification[1] for
> improving interoperability.
>
> [1] https://w3c.github.io/clipboard-apis/#to-fire-a-clipboard-event
>
> BUG=690104
> TEST=webkit_unittests --gtest_filter=ClipboardEventFlowTest.*
>
> Review-Url: https://codereview.chromium.org/2685723005
> Cr-Commit-Position: refs/heads/master@{#451716}
> Committed: https://chromium.googlesource.com/chromium/src/+/7afbab0f7619c89aa7a5896024d1628a59cc0ef1
TBR=tkent@chromium.org,ojan@chromium.org,yosin@chromium.org,yutak@chromium.org,sigbjornf@opera.com,mwrobel@opera.com
BUG=690104
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2745813002
Cr-Commit-Position: refs/heads/master@{#456232}
(cherry picked from commit 0b5fb5f6ef0d0deba7d706424cc3a05365172b1a)
Review-Url: https://codereview.chromium.org/2745353002
Cr-Commit-Position: refs/branch-heads/3029@{#179}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/ea1abaf0d7e6c26dc323607901c91b27a72e4979
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||