Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2745353002: Revert of evaluating clipboard event target acording to w3c specification (patchset #7 id:120001 of… (Closed)

Created:
3 years, 9 months ago by luoe
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of evaluating clipboard event target acording to w3c specification (patchset #7 id:120001 of https://codereview.chromium.org/2685723005/ ) Reason for revert: Changing this functionality improved spec conformance, but introduced regressions where text that used to be copied is no longer copied: crbug.com/695568 crbug.com/700163 A proposal to change the spec was made here: https://github.com/w3c/clipboard-apis/issues/40 Original issue's description: > Make Editor::findEventTargetFrom() to align Clipboard API specification > > This patch changes |Editor::findEventTargetFrom()| to return focused element if > selection start is not editable to align Clipboard API specification[1] for > improving interoperability. > > [1] https://w3c.github.io/clipboard-apis/#to-fire-a-clipboard-event > > BUG=690104 > TEST=webkit_unittests --gtest_filter=ClipboardEventFlowTest.* > > Review-Url: https://codereview.chromium.org/2685723005 > Cr-Commit-Position: refs/heads/master@{#451716} > Committed: https://chromium.googlesource.com/chromium/src/+/7afbab0f7619c89aa7a5896024d1628a59cc0ef1 TBR=tkent@chromium.org,ojan@chromium.org,yosin@chromium.org,yutak@chromium.org,sigbjornf@opera.com,mwrobel@opera.com BUG=690104 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2745813002 Cr-Commit-Position: refs/heads/master@{#456232} (cherry picked from commit 0b5fb5f6ef0d0deba7d706424cc3a05365172b1a) Review-Url: https://codereview.chromium.org/2745353002 Cr-Commit-Position: refs/branch-heads/3029@{#179} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/ea1abaf0d7e6c26dc323607901c91b27a72e4979

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -158 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/onpaste-text-html-types.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/editing/ClipboardEventFlowTest.cpp View 1 chunk +0 lines, -149 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
luoe
Could someone with editing knowledge please take a look? The cherry pick applied cleanly without ...
3 years, 9 months ago (2017-03-14 00:01:15 UTC) #4
yosin_UTC9
lgtm It seems the clipboard API spec will align current Blink implementation.
3 years, 9 months ago (2017-03-14 01:48:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745353002/1
3 years, 9 months ago (2017-03-14 03:19:50 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 9 months ago (2017-03-14 03:19:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745353002/1
3 years, 9 months ago (2017-03-14 03:42:24 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 03:45:35 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea1abaf0d7e6c26dc323607901c9...

Powered by Google App Engine
This is Rietveld 408576698