Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 274533004: clang: Turn on -Wabsolute-value. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
hans, sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

clang: Turn on -Wabsolute-value. BUG=351479 TBR=hans@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271732

Patch Set 1 #

Patch Set 2 : mesa #

Patch Set 3 : mesaer #

Patch Set 4 : cast #

Patch Set 5 : cros #

Patch Set 6 : exif #

Patch Set 7 : ash1 #

Patch Set 8 : ash2 #

Patch Set 9 : ash3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -6 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M ash/touch/touch_uma.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 6 3 chunks +0 lines, -7 lines 0 comments Download
M media/cast/audio_sender/audio_encoder_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libexif/libexif.gyp View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M third_party/mesa/mesa.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
6 years, 7 months ago (2014-05-20 19:33:05 UTC) #1
Nico
(tbr'ing since warning changes are tricky to land)
6 years, 7 months ago (2014-05-20 19:37:29 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 7 months ago (2014-05-20 19:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/274533004/160001
6 years, 7 months ago (2014-05-20 19:39:45 UTC) #4
Nico
Committed patchset #9 manually as r271732 (tree was closed).
6 years, 7 months ago (2014-05-20 19:50:49 UTC) #5
sadrul
lgtm
6 years, 7 months ago (2014-05-20 19:54:23 UTC) #6
hans
6 years, 7 months ago (2014-05-20 20:19:25 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698