Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 274533004: clang: Turn on -Wabsolute-value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ash3 Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/immersive_fullscreen_controller.cc ('k') | media/cast/audio_sender/audio_encoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 6ab9f69dd785176cae19569ebdf67ddec0eddae4..69f5a1c5700ed6055d3c465a4f53439752f92c66 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3680,9 +3680,6 @@
# code generated by flex (used in angle) contains that keyword.
# http://crbug.com/255186
'-Wno-deprecated-register',
-
- # TODO(thakis): Remove, http://crbug.com/341352
- '-Wno-absolute-value',
],
'cflags!': [
# Clang doesn't seem to know know this flag.
@@ -4430,9 +4427,6 @@
# keyword. http://crbug.com/255186
'-Wno-deprecated-register',
- # TODO(thakis): Remove, http://crbug.com/341352
- '-Wno-absolute-value',
-
# This warns on selectors from Cocoa headers (-length, -set).
# cfe-dev is currently discussing the merits of this warning.
# TODO(thakis): Reevaluate what to do with this, based one
@@ -5073,7 +5067,6 @@
'-Wno-missing-braces',
'-Wno-missing-declarations',
'-Wno-msvc-include',
- '-Wno-absolute-value',
'-Wno-null-dereference',
'-Wno-overloaded-virtual',
'-Wno-parentheses',
« no previous file with comments | « ash/wm/immersive_fullscreen_controller.cc ('k') | media/cast/audio_sender/audio_encoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698