Adding std::ostream& operator<<(std::ostream& out, NSError* error)

Adding std::ostream& operator<<(std::ostream& out, NSError* error)

BUG=624811
Review-Url: https://codereview.chromium.org/2745323002
Cr-Commit-Position: refs/heads/master@{#460854}
Committed: https://chromium.googlesource.com/chromium/src/+/568d1b3fc68429c453b883e67db2389c74892c4e

[jlebel, 2017-03-16 21:31:10]

Patchset #1 (id:1) has been deleted

[jlebel, 2017-03-16 21:31:25]

Patchset #1 (id:20001) has been deleted

[jlebel, 2017-03-22 22:56:05]

Patchset #1 (id:40001) has been deleted

[jlebel, 2017-03-22 22:56:26]

Description was changed from

==========
Adding BluetoothDeviceMac::GetStringFromNSError()

BUG=624811
==========

to

==========
Adding std::ostream& operator<<(std::ostream& out, NSError* error)

BUG=624811
==========

[jlebel, 2017-03-22 22:59:01]

jlebel@chromium.org changed reviewers:
+ scheib@chromium.org

[jlebel, 2017-03-22 22:59:02]

Hello Vincent,

I would like to add this function so we can easily log NSError. I'm not sure
bluetooth_device_mac.mm is the best file to put it.
What do you think?

Thanks,

[scheib, 2017-03-22 23:59:18]

scheib@chromium.org changed reviewers:
+ mark@chromium.org

[scheib, 2017-03-22 23:59:19]

mark, help us know where to put stream operator for NSError?

I like this approach. Probably another file, maybe src/base/mac/mac_util.h?

[jlebel, 2017-03-28 22:14:37]

Patchset #3 (id:100001) has been deleted

[jlebel, 2017-03-28 22:15:24]

Hello Mark,

Can you review this patch to add operator<< for NSError*?

Thanks,

[scheib, 2017-03-30 17:30:57]

scheib@chromium.org changed reviewers:
+ thakis@chromium.org

[scheib, 2017-03-30 17:30:58]

Nico, would you help us know where to put stream operator for NSError?

I like this approach. Probably another file, maybe src/base/mac/mac_util.h?

[Nico, 2017-03-30 17:44:26]

If you only need it in bluetooth device code, put it there. See base/OWNERS for
the general "don't put stuff in base" spiel.

In general, we don't like logging in chrome. Add temporary logging when you're
actively debugging something, and else don't put in logging. It bloats the
binary, and most times YAGNI.

[jlebel, 2017-03-30 17:47:08]

On 2017/03/30 17:44:26, Nico (afk until Tue Apr 4) wrote:
> If you only need it in bluetooth device code, put it there. See base/OWNERS
for
> the general "don't put stuff in base" spiel.
> 
> In general, we don't like logging in chrome. Add temporary logging when you're
> actively debugging something, and else don't put in logging. It bloats the
> binary, and most times YAGNI.

ok, I will add it in device/bluetooth

Thanks,

[scheib, 2017-03-30 17:47:28]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[jlebel, 2017-03-30 17:47:40]

Patchset #3 (id:120001) has been deleted

[jlebel, 2017-03-30 17:47:50]

jlebel@chromium.org changed reviewers:
- mark@chromium.org, thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 17:48:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2017-03-30 17:52:24]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2017-03-30 17:52:27]

The CQ bit was checked by scheib@chromium.org

[scheib, 2017-03-30 17:52:27]

lgtm

[commit-bot: I haz the power, 2017-03-30 17:52:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jlebel, 2017-03-30 17:59:30]

The CQ bit was unchecked by jlebel@chromium.org

[jlebel, 2017-03-30 18:24:16]

The CQ bit was checked by jlebel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 18:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 19:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 19:29:56]

Dry run: This issue passed the CQ dry run.

[jlebel, 2017-03-30 19:30:21]

The CQ bit was checked by jlebel@chromium.org

[jlebel, 2017-03-30 19:30:21]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2745323002/#ps140001
(title: "Moving operator<< to bluetooth_adapter_mac.mm")

[commit-bot: I haz the power, 2017-03-30 19:31:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 19:43:29]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1490902221269210,
"parent_rev": "9c03a0c535466dd59dd578e1d180863dbe3f1fd9", "commit_rev":
"568d1b3fc68429c453b883e67db2389c74892c4e"}

[commit-bot: I haz the power, 2017-03-30 19:44:45]

Description was changed from

==========
Adding std::ostream& operator<<(std::ostream& out, NSError* error)

BUG=624811
==========

to

==========
Adding std::ostream& operator<<(std::ostream& out, NSError* error)

BUG=624811

Review-Url: https://codereview.chromium.org/2745323002
Cr-Commit-Position: refs/heads/master@{#460854}
Committed:
https://chromium.googlesource.com/chromium/src/+/568d1b3fc68429c453b883e67db2...
==========

[commit-bot: I haz the power, 2017-03-30 19:44:49]

Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/568d1b3fc68429c453b883e67db2...