Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 2745303002: Make .clang-format files smaller after clang-format roll (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by Dan Beam (no longer on Chrome)
Modified:
7 months, 1 week ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, oshima+watch_chromium.org, arv+watch_chromium.org, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make .clang-format files smaller after clang-format roll -style=Chromium now enables include sorting implicitly, so no need to turn that on explicitly anymore. Likewise, AllowShortFunctionsOnASingleLine now defaults to Empty. Finally, all grit instructions in .js files are now in comments (when they can be), so `JavaScriptQuotes: Leave` is no longer needed either. No intended behavior change. Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>; BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2745303002 Cr-Commit-Position: refs/heads/master@{#457024} Committed: https://chromium.googlesource.com/chromium/src/+/8d9c69e2ce36013e57b553ce6ebdce48dcc2e522

Patch Set 1 #

Total comments: 2

Patch Set 2 : clang-format offer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M .clang-format View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
M components/dom_distiller/core/javascript/domdistiller.js View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/keyboard/resources/locales/en.js View 1 1 chunk +6 lines, -1 line 0 comments Download
D ui/webui/resources/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/webui/resources/js/analytics.js View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/webui/resources/js/jstemplate_compiled.js View 1 chunk +6 lines, -0 lines 0 comments Download
Trybot results:  linux_android_rel_ng   ios-simulator   win_clang   win_chromium_compile_dbg_ng   ios-device-xcode-clang   mac_chromium_compile_dbg_ng   android_clang_dbg_recipe   linux_android_rel_ng   android_compile_dbg   chromium_presubmit   win_chromium_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_compile_dbg_ng   android_arm64_dbg_recipe   mac_chromium_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   cast_shell_android   cast_shell_linux   ios-simulator-xcode-clang   chromeos_amd64-generic_chromium_compile_only_ng   ios-simulator   closure_compilation   chromeos_daisy_chromium_compile_only_ng   linux_chromium_rel_ng   linux_chromium_tsan_rel_ng   win_chromium_x64_rel_ng   android_n5x_swarming_rel   ios-device   android_cronet   win_clang   win_chromium_compile_dbg_ng   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   win_chromium_x64_rel_ng   ios-device   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-simulator   win_chromium_rel_ng   android_clang_dbg_recipe   linux_chromium_asan_rel_ng   android_cronet   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_tsan_rel_ng   android_arm64_dbg_recipe   chromeos_daisy_chromium_compile_only_ng   android_compile_dbg   closure_compilation   cast_shell_android   cast_shell_linux   linux_chromium_compile_dbg_ng   chromium_presubmit   linux_android_rel_ng   android_n5x_swarming_rel   linux_chromium_chromeos_rel_ng 
Commit queue not available (can’t edit this change).

Messages

Total messages: 26 (17 generated)
Dan Beam (no longer on Chrome)
7 months, 1 week ago (2017-03-13 20:40:52 UTC) #2
Dan Beam (no longer on Chrome)
7 months, 1 week ago (2017-03-13 20:41:07 UTC) #5
Nico
lgtm, thanks! https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/locales/en.js File ui/keyboard/resources/locales/en.js (right): https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/locales/en.js#newcode7 ui/keyboard/resources/locales/en.js:7: // of a licence header. Also, the ...
7 months, 1 week ago (2017-03-13 20:51:40 UTC) #8
Dan Beam (no longer on Chrome)
https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/locales/en.js File ui/keyboard/resources/locales/en.js (right): https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/locales/en.js#newcode7 ui/keyboard/resources/locales/en.js:7: // of a licence header. Also, the result is ...
7 months, 1 week ago (2017-03-13 20:54:09 UTC) #9
Dan Beam (no longer on Chrome)
+brettw@ for src/.clang-format and general owners stamp (only comment changes in components/dom_distiller and ui/keyboard)
7 months, 1 week ago (2017-03-13 20:56:48 UTC) #14
Dan Beam (no longer on Chrome)
ping brettw@
7 months, 1 week ago (2017-03-15 00:19:18 UTC) #19
brettw
I don't fully understand this, but if Nico thinks it's good, LGTM.
7 months, 1 week ago (2017-03-15 04:58:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745303002/20001
7 months, 1 week ago (2017-03-15 05:51:37 UTC) #23
commit-bot: I haz the power
7 months, 1 week ago (2017-03-15 07:24:35 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8d9c69e2ce36013e57b553ce6ebd...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa