Make .clang-format files smaller after clang-format roll

Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>;

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745303002
Cr-Commit-Position: refs/heads/master@{#457024}
Committed: https://chromium.googlesource.com/chromium/src/+/8d9c69e2ce36013e57b553ce6ebdce48dcc2e522

[Dan Beam, 2017-03-13 20:39:50]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-13 20:41:02]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-13 20:41:02]

dbeam@chromium.org changed reviewers:
+ thakis@chromium.org

[Dan Beam, 2017-03-13 20:41:33]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:42:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-13 20:51:40]

lgtm, thanks!

https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/local...
File ui/keyboard/resources/locales/en.js (right):

https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/local...
ui/keyboard/resources/locales/en.js:7: // of a licence header. Also, the result
is used in an assignment.
should this have a //clang-format: off comment too? If you `git cl format --js`
this file, it currently gets corrupted

[Dan Beam, 2017-03-13 20:54:09]

https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/local...
File ui/keyboard/resources/locales/en.js (right):

https://codereview.chromium.org/2745303002/diff/1/ui/keyboard/resources/local...
ui/keyboard/resources/locales/en.js:7: // of a licence header. Also, the result
is used in an assignment.
On 2017/03/13 20:51:40, Nico wrote:
> should this have a //clang-format: off comment too? If you `git cl format
--js`
> this file, it currently gets corrupted

yes, thanks for catching

[Dan Beam, 2017-03-13 20:55:02]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
TBR=wychen@chromium.org,
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-13 20:55:23]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
TBR=wychen@chromium.org,
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
TBR=wychen@chromium.org,bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-13 20:55:59]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
TBR=wychen@chromium.org,bshe@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-13 20:56:47]

dbeam@chromium.org changed reviewers:
+ brettw@chromium.org

[Dan Beam, 2017-03-13 20:56:48]

+brettw@ for src/.clang-format and general owners stamp (only comment changes in
components/dom_distiller and ui/keyboard)

[Dan Beam, 2017-03-13 20:57:08]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 20:58:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 22:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 22:03:46]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-03-15 00:19:18]

ping brettw@

[brettw, 2017-03-15 04:58:01]

I don't fully understand this, but if Nico thinks it's good, LGTM.

[Dan Beam, 2017-03-15 05:51:16]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-03-15 05:51:16]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2745303002/#ps20001
(title: "clang-format offer")

[commit-bot: I haz the power, 2017-03-15 05:51:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 07:23:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489557076157420,
"parent_rev": "dbc2181893710f3af2059b96bff4caf2db29f1f6", "commit_rev":
"8d9c69e2ce36013e57b553ce6ebdce48dcc2e522"}

[commit-bot: I haz the power, 2017-03-15 07:24:33]

Description was changed from

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Make .clang-format files smaller after clang-format roll

-style=Chromium now enables include sorting implicitly, so no need to
turn that on explicitly anymore. Likewise,
AllowShortFunctionsOnASingleLine now defaults to Empty.

Finally, all grit instructions in .js files are now in comments (when
they can be), so `JavaScriptQuotes: Leave` is no longer needed either.

No intended behavior change.

Based on https://crrev.com/2729033002/ by Nico <thakis@chromium.org>

BUG=567770
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2745303002
Cr-Commit-Position: refs/heads/master@{#457024}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d9c69e2ce36013e57b553ce6ebd...
==========

[commit-bot: I haz the power, 2017-03-15 07:24:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8d9c69e2ce36013e57b553ce6ebd...