third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html - Issue 2745283002: DevTools: merge coverage segments from different instances of same URL

Unified Diff: third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html

Issue 2745283002: DevTools: merge coverage segments from different instances of same URL (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/coverage/gutter-js.html ('k') | third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html

diff --git a/third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html b/third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html

similarity index 52%

copy from third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html

copy to third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html

index 0f069491e807d74d605fa0b78737a53fa04ca060..795c9010d798f0fbae359a84ec82d3f6d0a4708b 100644

--- a/third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html

+++ b/third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html

@@ -1,7 +1,7 @@

<html>

<head>

-<script src="../../http/tests/inspector/elements-test.js"></script>

+<script src="../../http/tests/inspector/debugger-test.js"></script>

@@ -11,26 +11,40 @@

async function test()

{

InspectorTest.startCoverage();

- await InspectorTest.evaluateInPagePromise("performActions()");

+ await InspectorTest.evaluateInPagePromise("performActions(); frames[0].performActionsInFrame()");

await InspectorTest.stopCoverage();

var coverageView = self.runtime.sharedInstance(Coverage.CoverageView);

var dataGrid = coverageView._listView._dataGrid;

for (var child of dataGrid.rootNode().children) {

var data = child._coverageInfo;

- var url = InspectorTest.formatters.formatAsURL(data.contentProvider.contentURL());

+ var url = InspectorTest.formatters.formatAsURL(data.url());

if (url.endsWith("-test.js") || url.endsWith(".html"))

continue;

- var type = Coverage.CoverageListView._typeToString(data.type);

- InspectorTest.addResult(`${url} ${type} used: ${data.usedSize} unused: ${data.unusedSize} total: ${data.size}`);

+ var type = Coverage.CoverageListView._typeToString(data.type());

+ InspectorTest.addResult(`${url} ${type} used: ${data.usedSize()} unused: ${data.unusedSize()} total: ${data.size()}`);

}

+ await dumpDecorationsInFile("highlight-in-source.css");

+ await dumpDecorationsInFile("coverage.js");

InspectorTest.completeTest();

+ async function dumpDecorationsInFile(file)

+ {

+ await InspectorTest.sourceDecorated(file);

+ var lines = Array.prototype.map.call(document.querySelectorAll(".text-editor-coverage-unused-marker"),

+ e => e.parentElement.previousSibling.textContent);

+ InspectorTest.addResult(`Unused lines in ${file}`);

+ InspectorTest.addResult(lines);

+ }

}

</script>

</head>

+<iframe src="resources/subframe.html"></iframe>

Tests the coverage list view after finishing recording in the Coverage view.

</p>