Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2745283002: DevTools: merge coverage segments from different instances of same URL (Closed)

Created:
3 years, 9 months ago by caseq
Modified:
3 years, 9 months ago
Reviewers:
alph, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: merge coverage segments from different instances of same URL This fixes a problem where for multiple occurrences of a resource with same URL (a stylesheet or script reused in multiple frames) coverage stats were just added together rather than being properly merged. Review-Url: https://codereview.chromium.org/2745283002 Cr-Commit-Position: refs/heads/master@{#456541} Committed: https://chromium.googlesource.com/chromium/src/+/97f425de047bcfa18633635370133d3eab7ee460

Patch Set 1 : cleanup #

Total comments: 2

Patch Set 2 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+409 lines, -168 lines) Patch
M third_party/WebKit/LayoutTests/inspector/coverage/coverage-view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/coverage/gutter-css.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/coverage/gutter-js.html View 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge.html View 2 chunks +19 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/coverage/resources/subframe.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/coverage/segments-merge.html View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/coverage/segments-merge-expected.txt View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js View 5 chunks +14 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js View 1 7 chunks +251 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js View 3 chunks +9 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
caseq
3 years, 9 months ago (2017-03-13 20:26:09 UTC) #4
alph
lgtm https://codereview.chromium.org/2745283002/diff/40001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js File third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js (right): https://codereview.chromium.org/2745283002/diff/40001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js#newcode128 third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js:128: return []; return https://codereview.chromium.org/2745283002/diff/40001/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js#newcode347 third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js:347: return; return [];
3 years, 9 months ago (2017-03-13 20:59:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745283002/60001
3 years, 9 months ago (2017-03-13 21:14:12 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:30:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/97f425de047bcfa1863363537013...

Powered by Google App Engine
This is Rietveld 408576698