Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2745223003:
Update the scale factor for font param before querying the default font (Closed)
|
Created:
3 years, 9 months ago by oshima Modified:
3 years, 9 months ago Reviewers:
Elliot Glaysher CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate the scale factor for font param before querying the default font.
The very first time the default font is queried may use 1.0 when dsf isn't 1.0.
BUG=698075
TEST=manual.
Review-Url: https://codereview.chromium.org/2745223003
Cr-Commit-Position: refs/heads/master@{#457036}
Committed: https://chromium.googlesource.com/chromium/src/+/bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4
Patch Set 1 : . #
Messages
Total messages: 24 (20 generated)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Description was changed from ========== Fix font Speculative fix for wrong scale factor being used to pick font parameter. BUG=698075 ========== to ========== Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0f even if it's not. BUG=698075 TEST=manual. ==========
oshima@chromium.org changed reviewers: + erg@chromium.org
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0f even if it's not. BUG=698075 TEST=manual. ========== to ========== Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0 when dsf isn't 1.0. BUG=698075 TEST=manual. ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489567738627020,
"parent_rev": "886e0b3390e48ca2dd0a361b9e27b84e73b0acc4", "commit_rev":
"bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4"}
Message was sent while issue was closed.
Description was changed from ========== Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0 when dsf isn't 1.0. BUG=698075 TEST=manual. ========== to ========== Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0 when dsf isn't 1.0. BUG=698075 TEST=manual. Review-Url: https://codereview.chromium.org/2745223003 Cr-Commit-Position: refs/heads/master@{#457036} Committed: https://chromium.googlesource.com/chromium/src/+/bcf3cc76c4dd7e474e6c458fcd5a... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bcf3cc76c4dd7e474e6c458fcd5a... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
