Ensure that FormFetcher state is WAITING when waiting for migration

Ensure that FormFetcher state is WAITING when waiting for migration

FormFetcher has a state which indicates whether it is waiting for PasswordStore
results. It should be useful to know when the stored data corresponds to some
real snapshot of PasswordStore.

FormFetcher can be waiting for the PasswordStore either directly, or indirectly
through waiting for HttpPasswordMigrator. So far, it only keeps the state as
WAITING during the first type of waiting.

This CL expands the state WAITING to also mean "waiting for
HttpPasswordMigrator".

BUG=571580
Review-Url: https://codereview.chromium.org/2745173008
Cr-Commit-Position: refs/heads/master@{#457447}
Committed: https://chromium.googlesource.com/chromium/src/+/291a91bc6d4215a2fe2df3ebf41a9eac60e0cdb8

[vabr (Chromium), 2017-03-16 12:01:42]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 12:01:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 13:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 13:06:10]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2017-03-16 13:20:19]

vabr@chromium.org changed reviewers:
+ jdoerrie@chromium.org

[vabr (Chromium), 2017-03-16 13:20:20]

Hi Jan,

Another change in this area, could you please review?

Cheers,
Vaclav

[jdoerrie, 2017-03-16 14:03:23]

On 2017/03/16 13:20:20, vabr (Chromium) wrote:
> Hi Jan,
> 
> Another change in this area, could you please review?
> 
> Cheers,
> Vaclav

LGTM. Thanks, Vaclav!

[jdoerrie, 2017-03-16 14:03:33]

https://codereview.chromium.org/2745173008/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2745173008/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:533:
form_fetcher_ = base::MakeUnique<MockFormFetcherImpl>(
You probably want to rebase on http://crrev.com/2756543004 :)

[vabr (Chromium), 2017-03-16 14:42:04]

Thanks!

https://codereview.chromium.org/2745173008/diff/1/components/password_manager...
File components/password_manager/core/browser/form_fetcher_impl_unittest.cc
(right):

https://codereview.chromium.org/2745173008/diff/1/components/password_manager...
components/password_manager/core/browser/form_fetcher_impl_unittest.cc:533:
form_fetcher_ = base::MakeUnique<MockFormFetcherImpl>(
On 2017/03/16 14:03:32, jdoerrie wrote:
> You probably want to rebase on http://crrev.com/2756543004 :)

Oops, rebasing would not help with my blind copypasting. Thanks for spotting
this. :)

[vabr (Chromium), 2017-03-16 14:42:07]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2017-03-16 14:42:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdoerrie@chromium.org
Link to the patchset: https://codereview.chromium.org/2745173008/#ps40001
(title: "Fix rebase")

[commit-bot: I haz the power, 2017-03-16 14:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 15:54:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489675327683290,
"parent_rev": "293b1855e6df88132db0ff0f5dd55ff835f8d7c0", "commit_rev":
"291a91bc6d4215a2fe2df3ebf41a9eac60e0cdb8"}

[commit-bot: I haz the power, 2017-03-16 15:55:19]

Description was changed from

==========
Ensure that FormFetcher state is WAITING when waiting for migration

FormFetcher has a state which indicates whether it is waiting for PasswordStore
results. It should be useful to know when the stored data corresponds to some
real snapshot of PasswordStore.

FormFetcher can be waiting for the PasswordStore either directly, or indirectly
through waiting for HttpPasswordMigrator. So far, it only keeps the state as
WAITING during the first type of waiting.

This CL expands the state WAITING to also mean "waiting for
HttpPasswordMigrator".

BUG=571580
==========

to

==========
Ensure that FormFetcher state is WAITING when waiting for migration

FormFetcher has a state which indicates whether it is waiting for PasswordStore
results. It should be useful to know when the stored data corresponds to some
real snapshot of PasswordStore.

FormFetcher can be waiting for the PasswordStore either directly, or indirectly
through waiting for HttpPasswordMigrator. So far, it only keeps the state as
WAITING during the first type of waiting.

This CL expands the state WAITING to also mean "waiting for
HttpPasswordMigrator".

BUG=571580

Review-Url: https://codereview.chromium.org/2745173008
Cr-Commit-Position: refs/heads/master@{#457447}
Committed:
https://chromium.googlesource.com/chromium/src/+/291a91bc6d4215a2fe2df3ebf41a...
==========

[commit-bot: I haz the power, 2017-03-16 15:55:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/291a91bc6d4215a2fe2df3ebf41a...