Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2745173004:
Updating device scale factor thresholds (Closed)
|
Created:
3 years, 9 months ago by malaykeshav Modified:
3 years, 9 months ago Reviewers:
oshima CC:
chromium-reviews, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdates the device scale factor clamping intervals to
1x = ... to 150
1.25x = 151 to 180
1.5x = 181 to 220
2x = 221 to ...
BUG=701455
COMPONENT=DisplayChangeObserver, Device Scale Factor
Review-Url: https://codereview.chromium.org/2745173004
Cr-Commit-Position: refs/heads/master@{#457562}
Committed: https://chromium.googlesource.com/chromium/src/+/bc59a7a79efc1149ecb849cb6427d61045383298
Patch Set 1 #Patch Set 2 : Updates the device scale factor clamping intervals to #
Messages
Total messages: 26 (22 generated)
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Foo BUG= ========== to ========== Updates the device scale factor clamping intervals to 1x = ... to 150 1.25x = 151 to 180 1.5x = 181 to 220 2x = 221 to ... BUG=701455 COMPONENT=DisplayChangeObserver, Device Scale Factor ==========
malaykeshav@chromium.org changed reviewers: + oshima@chromium.org
PTAL
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
please double check 2x dvices (samus and caroline) are covered in the test, then lgtm
The CQ bit was checked by malaykeshav@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by malaykeshav@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org Link to the patchset: https://codereview.chromium.org/2745173004/#ps60001 (title: "Updates the device scale factor clamping intervals to")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489699517439070,
"parent_rev": "7bc04f5e1bfff73c5ed2077690fa89649ea12566", "commit_rev":
"bc59a7a79efc1149ecb849cb6427d61045383298"}
Message was sent while issue was closed.
Description was changed from ========== Updates the device scale factor clamping intervals to 1x = ... to 150 1.25x = 151 to 180 1.5x = 181 to 220 2x = 221 to ... BUG=701455 COMPONENT=DisplayChangeObserver, Device Scale Factor ========== to ========== Updates the device scale factor clamping intervals to 1x = ... to 150 1.25x = 151 to 180 1.5x = 181 to 220 2x = 221 to ... BUG=701455 COMPONENT=DisplayChangeObserver, Device Scale Factor Review-Url: https://codereview.chromium.org/2745173004 Cr-Commit-Position: refs/heads/master@{#457562} Committed: https://chromium.googlesource.com/chromium/src/+/bc59a7a79efc1149ecb849cb6427... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bc59a7a79efc1149ecb849cb6427... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
